Re: mrep: Set From header according to To/Cc header

Re: mrep: Set From header according to To/Cc header

[leahneukirchen]

[-- Attachment #1: Type: text/plain, Size: 346 bytes --]

New comment by leahneukirchen on mblaze repository

https://github.com/leahneukirchen/mblaze/pull/173#issuecomment-605918055

Comment:
This is a good idea, but there are some cases that require more thought: if you are in Cc with address only, your from doesn't contain the real name e.g.

Probably an improvement over the status quo, however.

Re: mrep: Set From header according to To/Cc header

[leahneukirchen]

[-- Attachment #1: Type: text/plain, Size: 186 bytes --]

New comment by leahneukirchen on mblaze repository

https://github.com/leahneukirchen/mblaze/pull/173#issuecomment-633059832

Comment:
I mangled this into 282de65079f2a543, please test.

Re: mrep: Set From header according to To/Cc header

[leahneukirchen]

[-- Attachment #1: Type: text/plain, Size: 201 bytes --]

New comment by leahneukirchen on mblaze repository

https://github.com/leahneukirchen/mblaze/pull/173#issuecomment-633056327

Comment:
Do we really need something more complicated than `@example.com`?

Re: mrep: Set From header according to To/Cc header

[xelxebar]

[-- Attachment #1: Type: text/plain, Size: 940 bytes --]

New comment by xelxebar on mblaze repository

https://github.com/leahneukirchen/mblaze/pull/173#issuecomment-631182431

Comment:
Have my eye on this feature. The list of emails I have to reply as is very long and constantly growing. Would it make sense to allow wildcards or regex specifications in `reply-from` and/or `alternative-mailboxes` specifications?

Unfortunately `*` and `/` can technically appear in the local and domain parts, so we can't use an obvious wildcard syntax like `*@example.com` nor a regex syntax like `/.*@example.com/`. Unwinding the address specification in rfc5322 is a bit of a windy path, but it looks like we could get away with using `\` of the `specials` (section [3.2.3][0]). AFAICT the backslash can't appear anywhere in an address specification so a regex like `\.*@example.com\` should be easily distinguishable and unambiguous.

Thoughts?

[0]:https://tools.ietf.org/html/rfc5322#section-3.2.3

Re: mrep: Set From header according to To/Cc header

[xelxebar]

[-- Attachment #1: Type: text/plain, Size: 923 bytes --]

New comment by xelxebar on mblaze repository

https://github.com/leahneukirchen/mblaze/pull/173#issuecomment-631182431

Comment:
Have my eye on this feature. The list of emails I have to reply as is very long and constantly growing. Would it make sense to allow wildcards or regex specifications in `reply-from` and/or `alternative-mailboxes` specifications?

Unfortunately `*` and `/` can technically appear in the local and domain parts, so we can't use an obvious wildcard syntax like `*@example.com` nor a regex syntax like `/.*@example.com/`. Unwinding the address specification in rfc5322 is a bit of a windy path, but it looks like we could get away with using `\` of the `specials` [0]. AFAICT the backslash can't appear anywhere in an address specification so a regex like `\.*@example.com\` should be easily distinguishable and unambiguous.

Thoughts?

[0]:https://tools.ietf.org/html/rfc5322#section-3.2.3

Re: mrep: Set From header according to To/Cc header

[nmeum]

[-- Attachment #1: Type: text/plain, Size: 165 bytes --]

New comment by nmeum on mblaze repository

https://github.com/leahneukirchen/mblaze/pull/173#issuecomment-616588304

Comment:
Added some experimental fallback code.

Re: mrep: Set From header according to To/Cc header

[nmeum]

[-- Attachment #1: Type: text/plain, Size: 598 bytes --]

New comment by nmeum on mblaze repository

https://github.com/leahneukirchen/mblaze/pull/173#issuecomment-616580590

Comment:
> We could default to `Alternative-Mailboxes` when `Reply-From` is unset.

Sure but imho that would complicate the code a bit (more case distinctions) as the fallback is needed both here:

https://github.com/leahneukirchen/mblaze/blob/4e4dcdf1cab41e975139bf62d666ed16594507df/mcom#L19-L20

and here:

https://github.com/leahneukirchen/mblaze/blob/4e4dcdf1cab41e975139bf62d666ed16594507df/mcom#L367

> Sorry, I lost track of this PR in my todo list.

So did I.

Re: mrep: Set From header according to To/Cc header

[leahneukirchen]

[-- Attachment #1: Type: text/plain, Size: 258 bytes --]

New comment by leahneukirchen on mblaze repository

https://github.com/leahneukirchen/mblaze/pull/173#issuecomment-616572197

Comment:
We could default to `Alternative-Mailboxes` when `Reply-From` is unset.

Sorry, I lost track of this PR in my todo list.

Re: mrep: Set From header according to To/Cc header

[nmeum]

[-- Attachment #1: Type: text/plain, Size: 370 bytes --]

New comment by nmeum on mblaze repository

https://github.com/leahneukirchen/mblaze/pull/173#issuecomment-616567773

Comment:
Implemented (i.e. copied) your implementation. Also added some documentation to `mblaze-profile(5)`. The downside of this implementation is that you end of with a lot of duplicate address in `mblaze-profile(5)` at least for my simple use-case.

Re: mrep: Set From header according to To/Cc header

[nmeum]

[-- Attachment #1: Type: text/plain, Size: 366 bytes --]

New comment by nmeum on mblaze repository

https://github.com/leahneukirchen/mblaze/pull/173#issuecomment-616567773

Comment:
Implemented (i.e. copied) your suggestion. Also added some documentation to `mblaze-profile(5)`. The downside of this implementation is that you end of with a lot of duplicate address in `mblaze-profile(5)` at least for my simple use-case.

Re: mrep: Set From header according to To/Cc header

[nmeum]

[-- Attachment #1: Type: text/plain, Size: 370 bytes --]

New comment by nmeum on mblaze repository

https://github.com/leahneukirchen/mblaze/pull/173#issuecomment-616567773

Comment:
Implemented (i.e. copied) your implementation. Also added some documentation to `mblaze-profile(5)`. The downside of this implementation is that you end of with a lot of duplicate address in `mblaze-profile(5)` at least for my simple use-case.

Re: mrep: Set From header according to To/Cc header

[nmeum]

[-- Attachment #1: Type: text/plain, Size: 220 bytes --]

New comment by nmeum on mblaze repository

https://github.com/leahneukirchen/mblaze/pull/173#issuecomment-606174195

Comment:
> I'm thinking of a slightly more general feature, […]

Sure, that would work for me :+1:

Re: mrep: Set From header according to To/Cc header

[leahneukirchen]

[-- Attachment #1: Type: text/plain, Size: 251 bytes --]

New comment by leahneukirchen on mblaze repository

https://github.com/leahneukirchen/mblaze/pull/173#issuecomment-606153663

Comment:
We could default addrs to alternative-mailboxes if reply-from is empty (having full names there should also be ok).

Re: mrep: Set From header according to To/Cc header

[leahneukirchen]

[-- Attachment #1: Type: text/plain, Size: 572 bytes --]

New comment by leahneukirchen on mblaze repository

https://github.com/leahneukirchen/mblaze/pull/173#issuecomment-606152541

Comment:
I'm thinking of a slightly more general feature, something like

```
replyfrom() {
        addrs="$(maddr -a -h reply-from "$MBLAZE/profile")"
        grep -Fv -e "addrs"
}
addr=$(maddr -a -h to:cc:bcc: "$1" | replyfrom | head -n 1)
if [ -n "$addr" ]; then
	from=$(maddr -h reply-from "$MBLAZE/profile" | grep -xi -e "<$addr>" | head - n1)
fi
if [ -z "$from" ]; then
	from=$(mhdr -h local-mailbox "$MBLAZE/profile")
fi
```

Re: mrep: Set From header according to To/Cc header

[nmeum]

[-- Attachment #1: Type: text/plain, Size: 813 bytes --]

New comment by nmeum on mblaze repository

https://github.com/leahneukirchen/mblaze/pull/173#issuecomment-606149621

Comment:
> Well, I have some private addresses that are listed as Alternative-Mailboxes to get the sign, but that I don't use for replying.

It would certainly be possible to add a new `auto-reply-addresses` profile header setting (or something along the lines).

> Also, people could use From: addresses that are not in Alternative-Mailboxes (e.g. a shared helpdesk email).

Why would that be a problem? Unless I am missing something here the code should fallback to `local-mailbox` then.

If you generally disagree with the feature I will just apply my patch locally. If you like the idea in general but don't like the implementation I can try to adjust it. Either way is fine with me.

Re: mrep: Set From header according to To/Cc header

[nmeum]

[-- Attachment #1: Type: text/plain, Size: 782 bytes --]

New comment by nmeum on mblaze repository

https://github.com/leahneukirchen/mblaze/pull/173#issuecomment-606149621

Comment:
> Well, I have some private addresses that are listed as Alternative-Mailboxes to get the sign, but that I don't use for replying.

It would certainly be possible to add a new `auto-reply-addresses` profile header setting.

> Also, people could use From: addresses that are not in Alternative-Mailboxes (e.g. a shared helpdesk email).

Why would that be a problem? Unless I am missing something here the code should fallback to `local-mailbox` then.

If you generally disagree with the feature I will just apply my patch locally. If you like the idea in general but don't like the implementation I can try to adjust it. Either way is fine with me.

Re: mrep: Set From header according to To/Cc header

[nmeum]

[-- Attachment #1: Type: text/plain, Size: 781 bytes --]

New comment by nmeum on mblaze repository

https://github.com/leahneukirchen/mblaze/pull/173#issuecomment-606149621

Comment:
> Well, I have some private addresses that are listed as Alternative-Mailboxes to get the sign, but that I don't use for replying.

It would certainly be possible to add a new `auto-reply-addresses profile header setting.

> Also, people could use From: addresses that are not in Alternative-Mailboxes (e.g. a shared helpdesk email).

Why would that be a problem? Unless I am missing something here the code should fallback to `local-mailbox` then.

If you generally disagree with the feature I will just apply my patch locally. If you like the idea in general but don't like the implementation I can try to adjust it. Either way is fine with me.

Re: mrep: Set From header according to To/Cc header

[nmeum]

[-- Attachment #1: Type: text/plain, Size: 812 bytes --]

New comment by nmeum on mblaze repository

https://github.com/leahneukirchen/mblaze/pull/173#issuecomment-606149621

Comment:
> Well, I have some private addresses that are listed as Alternative-Mailboxes to get the sign, but that I don't use for replying.

It would certainly be possible to add a new `auto-reply-addresses` or something a long the lines profile header setting.

> Also, people could use From: addresses that are not in Alternative-Mailboxes (e.g. a shared helpdesk email).

Why would that be a problem? Unless I am missing something here the code should fallback to `local-mailbox` then.

If you generally disagree with the feature I will just apply my patch locally. If you like the idea in general but don't like the implementation I can try to adjust it. Either way is fine with me.

Re: mrep: Set From header according to To/Cc header

[leahneukirchen]

[-- Attachment #1: Type: text/plain, Size: 377 bytes --]

New comment by leahneukirchen on mblaze repository

https://github.com/leahneukirchen/mblaze/pull/173#issuecomment-606146950

Comment:
Well, I have some private addresses that are listed as Alternative-Mailboxes to get the `>` sign, but that I don't use for replying. Also, people could use From: addresses that are not in Alternative-Mailboxes (e.g. a shared helpdesk email).

Re: mrep: Set From header according to To/Cc header

[nmeum]

[-- Attachment #1: Type: text/plain, Size: 538 bytes --]

New comment by nmeum on mblaze repository

https://github.com/leahneukirchen/mblaze/pull/173#issuecomment-606145682

Comment:
The more compilated version which also handles a missing description in `local-mailbox` would be:

```shell
addr=$(maddr -a -h to:cc:bcc: "$1" | grepmine | head -n 1)
if [ -n "$addr" ]; then
	desc=$(maddr -d -h "local-mailbox" "$MBLAZE/profile")
	if [ -n "$desc" ]; then
		from=$(printf "%s <%s>" "$desc" "$addr")
	else
		from=$addr
	fi
else
	from=$(mhdr -h local-mailbox "$MBLAZE/profile")
fi
```

Re: mrep: Set From header according to To/Cc header

[nmeum]

[-- Attachment #1: Type: text/plain, Size: 806 bytes --]

New comment by nmeum on mblaze repository

https://github.com/leahneukirchen/mblaze/pull/173#issuecomment-606140041

Comment:
> I added `maddr -d`.

Pushed a change which utilities `maddr -d` to extract the description part form the `local-mailbox` and combines that with the address extracted from the To/Cc/Bcc header. I haven't handled the case where the `local-mailbox` configuration header doesn't contain a description. However, this should address your [original comment](https://github.com/leahneukirchen/mblaze/pull/173#issuecomment-605918055). I personally find that preferable to adding a new configuration header, let me know what you think.

> not sure we need that actually, but it's an obvious feature.

I personally find it very handy, but if you don't want it that's fine as well.

Re: mrep: Set From header according to To/Cc header

[leahneukirchen]

[-- Attachment #1: Type: text/plain, Size: 144 bytes --]

New comment by leahneukirchen on mblaze repository

https://github.com/leahneukirchen/mblaze/pull/173#issuecomment-606050252

Comment:
Exactly.

Re: mrep: Set From header according to To/Cc header

[nmeum]

[-- Attachment #1: Type: text/plain, Size: 385 bytes --]

New comment by nmeum on mblaze repository

https://github.com/leahneukirchen/mblaze/pull/173#issuecomment-606046386

Comment:
Just to make sure I understood you correctly: You are proposing adding an additional header to `mblaze-profile(5)` which contains a display name which is then combined with the address extracted from the To/Cc header and used as the From header in the reply?

Re: mrep: Set From header according to To/Cc header

[leahneukirchen]

[-- Attachment #1: Type: text/plain, Size: 264 bytes --]

New comment by leahneukirchen on mblaze repository

https://github.com/leahneukirchen/mblaze/pull/173#issuecomment-605986244

Comment:
Perhaps we can use a different header in the configuration for this feature.  Then map that by address to the given displayname.

Re: mrep: Set From header according to To/Cc header

[nmeum]

[-- Attachment #1: Type: text/plain, Size: 430 bytes --]

New comment by nmeum on mblaze repository

https://github.com/leahneukirchen/mblaze/pull/173#issuecomment-605981282

Comment:
> I think alternate-mailboxes should just contain the addresses.

Good to know, but the `Local-Mailbox` should definitely contain a valid RFC 5322 address, or at least mine does. In general, it might makes sense to use this as is and improve it later on when tooling around RFC 5322 has improved? idk.

Re: mrep: Set From header according to To/Cc header

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 548 bytes --]

New comment by Duncaen on mblaze repository

https://github.com/leahneukirchen/mblaze/pull/173#issuecomment-605959471

Comment:
`magrep` with `-a`  would be a good instead of grep, but it only matches all headers or one header at a time.

```
$ magrep -ha "to:mail@duncano.de|administrator@duncano.de" 100
to: administrator@duncano.de
$ mhdr -h to 100
Duncan Overbruck <administrator@duncano.de>
```

Edit: nvm, this doesn't really solve the problem, but might be better than a plain grep if someone messes with comments in addresses etc.

Re: mrep: Set From header according to To/Cc header

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 407 bytes --]

New comment by Duncaen on mblaze repository

https://github.com/leahneukirchen/mblaze/pull/173#issuecomment-605959471

Comment:
`magrep` with `-a`  would be a good instead of grep, but it only matches all headers or one header at a time.

```
$ magrep -ha "to:mail@duncano.de|administrator@duncano.de" 100
to: administrator@duncano.de
$ mhdr -h to 100
Duncan Overbruck <administrator@duncano.de>
```

Re: mrep: Set From header according to To/Cc header

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 344 bytes --]

New comment by Duncaen on mblaze repository

https://github.com/leahneukirchen/mblaze/pull/173#issuecomment-605959471

Comment:
`magrep` with `-a`  would be a good instead of grep, but it only matches all headers or one header at a time.

```
$ magrep -ha "to:mail@duncano.de|administrator@duncano.de" 100
to: administrator@duncano.de
```

Re: mrep: Set From header according to To/Cc header

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 313 bytes --]

New comment by Duncaen on mblaze repository

https://github.com/leahneukirchen/mblaze/pull/173#issuecomment-605959471

Comment:
`magrep` with `-a`  would be a good instead of grep, but it only matches all headers or one header at a time.

```
magrep -qa "to:mail@duncano.de|administrator@duncano.de" 1000
```

Re: mrep: Set From header according to To/Cc header

[leahneukirchen]

[-- Attachment #1: Type: text/plain, Size: 279 bytes --]

New comment by leahneukirchen on mblaze repository

https://github.com/leahneukirchen/mblaze/pull/173#issuecomment-605956990

Comment:
I think alternate-mailboxes should just contain the addresses.

maddr -a can print the address only, i guess adding maddr -d would be useful.

Re: mrep: Set From header according to To/Cc header

[nmeum]

[-- Attachment #1: Type: text/plain, Size: 664 bytes --]

New comment by nmeum on mblaze repository

https://github.com/leahneukirchen/mblaze/pull/173#issuecomment-605941675

Comment:
Good point, RFC 5322 addresses complicate this setup quite a bit. For example, my assumption was that `Alternate-Mailboxes` just contains the mail address but that's not necessarily the case, right? If so, it would probably make sense to modify `grepmine` in a way that it operates only on the mail address part and later map that address to the display name using a different function? Is there already any tool for extracting the display-name/mail-address part of an [RFC 5322 address](https://tools.ietf.org/html/rfc5322#section-3.4)?