From: timkuijsten <timkuijsten@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: pledge(2) all programs
Date: Sat, 08 Aug 2020 16:18:47 +0200 [thread overview]
Message-ID: <20200808141847.JGU9tRT2tlv0vYRLNX6_1imVSv4M6IEm-YdnOzVjnP4@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-fa6558a0-26e0-48f6-803f-f5a8af34f6a8-mblaze-179@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 701 bytes --]
New comment by timkuijsten on mblaze repository
https://github.com/leahneukirchen/mblaze/pull/179#issuecomment-670934343
Comment:
Thanks for looking at the PR.
> xpledge should be static. Why is including err.h everywhere required?
Both fixed now.
> Instead of changing _XOPEN_SOURCE, please define _BSD_SOURCE where needed (i.e. in xpledge.h)
I've restored the _XOPEN_SOURCE definition in mscan.h and defined _BSD_SOURCE in xpledge.h. I did have to hoist the xpledge.h include in mscan to make sure pledge(3) is defined. This fixes the issue. (I'm not quite sure why the same warning isn't triggered in mpick.c where _XOPEN_SOURCE is also set and unistd.h is included before xpledge.h)
next prev parent reply other threads:[~2020-08-08 14:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <gh-mailinglist-notifications-fa6558a0-26e0-48f6-803f-f5a8af34f6a8-mblaze-179@inbox.vuxu.org>
2020-08-03 17:39 ` leahneukirchen
2020-08-03 17:43 ` leahneukirchen
2020-08-08 14:12 ` [PR PATCH] [Updated] " timkuijsten
2020-08-08 14:18 ` timkuijsten [this message]
2020-08-12 8:43 ` leahneukirchen
2020-08-13 13:55 ` [PR PATCH] [Updated] " timkuijsten
2020-08-13 14:03 ` timkuijsten
2020-09-06 14:35 ` [PR PATCH] [Closed]: " leahneukirchen
2020-09-06 14:35 ` leahneukirchen
2020-09-10 17:46 ` timkuijsten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200808141847.JGU9tRT2tlv0vYRLNX6_1imVSv4M6IEm-YdnOzVjnP4@z \
--to=timkuijsten@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).