Github messages for mblaze
 help / color / mirror / Atom feed
* [PR PATCH] seq: fix infinite loop when selecting thread of orphaned message
@ 2020-08-10 20:12 jeremybobbin
  2020-08-10 20:23 ` leahneukirchen
  2020-08-10 20:23 ` [PR PATCH] [Closed]: " leahneukirchen
  0 siblings, 2 replies; 3+ messages in thread
From: jeremybobbin @ 2020-08-10 20:12 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 421 bytes --]

There is a new pull request by jeremybobbin against master on the mblaze repository

https://github.com/jeremybobbin/mblaze master
https://github.com/leahneukirchen/mblaze/pull/180

seq: fix infinite loop when selecting thread of orphaned message
To replicate the infinite loop:

```
printf ' a\n' | mseq -S
mseq .=
```

Thanks

A patch file from https://github.com/leahneukirchen/mblaze/pull/180.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-180.patch --]
[-- Type: text/x-diff, Size: 722 bytes --]

From 2812bebb5bc1d07e8f001d3347a36f2c34d88573 Mon Sep 17 00:00:00 2001
From: Jeremy Bobbin <jer@jer.cx>
Date: Mon, 10 Aug 2020 12:55:16 -0700
Subject: [PATCH] seq: fix infinite loop when selecting thread of orphaned
 message

printf ' a\n' | mseq -S
mseq .=
---
 seq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/seq.c b/seq.c
index 970e30b..a75ee3f 100644
--- a/seq.c
+++ b/seq.c
@@ -427,7 +427,7 @@ blaze822_seq_next(char *map, char *range, struct blaze822_seq_iter *iter)
 	if (!iter->lines)  // count total lines
 		find_cur(map, iter);
 
-	if (!iter->start) {
+	if (!iter->s) {
 		int ret = parse_range(map, range, &iter->start, &iter->stop,
 		    iter->cur, iter->lines);
 		if (ret == 1) {

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: seq: fix infinite loop when selecting thread of orphaned message
  2020-08-10 20:12 [PR PATCH] seq: fix infinite loop when selecting thread of orphaned message jeremybobbin
@ 2020-08-10 20:23 ` leahneukirchen
  2020-08-10 20:23 ` [PR PATCH] [Closed]: " leahneukirchen
  1 sibling, 0 replies; 3+ messages in thread
From: leahneukirchen @ 2020-08-10 20:23 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 143 bytes --]

New comment by leahneukirchen on mblaze repository

https://github.com/leahneukirchen/mblaze/pull/180#issuecomment-671571178

Comment:
Thanks!

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PR PATCH] [Closed]: seq: fix infinite loop when selecting thread of orphaned message
  2020-08-10 20:12 [PR PATCH] seq: fix infinite loop when selecting thread of orphaned message jeremybobbin
  2020-08-10 20:23 ` leahneukirchen
@ 2020-08-10 20:23 ` leahneukirchen
  1 sibling, 0 replies; 3+ messages in thread
From: leahneukirchen @ 2020-08-10 20:23 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 273 bytes --]

There's a closed pull request on the mblaze repository

seq: fix infinite loop when selecting thread of orphaned message
https://github.com/leahneukirchen/mblaze/pull/180

Description:
To replicate the infinite loop:

```
printf ' a\n' | mseq -S
mseq .=
```

Thanks

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-08-10 20:23 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-10 20:12 [PR PATCH] seq: fix infinite loop when selecting thread of orphaned message jeremybobbin
2020-08-10 20:23 ` leahneukirchen
2020-08-10 20:23 ` [PR PATCH] [Closed]: " leahneukirchen

Github messages for mblaze

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.vuxu.org/mblaze-github

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 mblaze-github mblaze-github/ http://inbox.vuxu.org/mblaze-github \
		mblaze-github@inbox.vuxu.org
	public-inbox-index mblaze-github

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.github.mblaze


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git