From: Duncaen <Duncaen@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: seq: fix printing multiple mmsgs
Date: Tue, 11 Aug 2020 14:23:28 +0200 [thread overview]
Message-ID: <20200811122328.pJCnLhYiJO3mwO0WXrQ0ztmaDZvliUBn0vFoXYMiN8E@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-fa6558a0-26e0-48f6-803f-f5a8af34f6a8-mblaze-181@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1108 bytes --]
New comment by Duncaen on mblaze repository
https://github.com/leahneukirchen/mblaze/pull/181#issuecomment-671913910
Comment:
Maybe also add the following test case to your PR:
http://ix.io/2tSu
```patch
From 9c88276bd5b42f7c233f8ded07b5d5db54006349 Mon Sep 17 00:00:00 2001
From: Duncan Overbruck <mail@duncano.de>
Date: Tue, 11 Aug 2020 14:21:07 +0200
Subject: [PATCH] t/7000-mseq.t: add test case for multiple mmsg arguments
---
t/7000-mseq.t | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/t/7000-mseq.t b/t/7000-mseq.t
index 4afa561..5566252 100644
--- a/t/7000-mseq.t
+++ b/t/7000-mseq.t
@@ -1,7 +1,7 @@
#!/bin/sh -e
cd ${0%/*}
. ./lib.sh
-plan 10
+plan 11
rm -rf test.dir
mkdir test.dir
@@ -31,6 +31,7 @@ check_test 'whole thread' -eq 4 'mseq 6= | wc -l'
check_test 'subthread' -eq 2 'mseq 7_ | wc -l'
check 'parent' 'mseq 6^ | grep "inbox/cur/5_1:2,"'
check_test 'range' -eq 3 'mseq 1:3 | wc -l'
+check_same 'multiple mmsg' 'mseq 1 2' 'echo "inbox/cur/1:2,\ninbox/cur/2:2,"'
cat <<! >seq
inbox/cur/1:2,
--
2.27.0
```
next prev parent reply other threads:[~2020-08-11 12:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-11 12:00 [PR PATCH] " jeremybobbin
2020-08-11 12:01 ` [PR PATCH] [Updated] " jeremybobbin
2020-08-11 12:23 ` Duncaen [this message]
2020-08-11 12:32 ` jeremybobbin
2020-08-11 12:35 ` jeremybobbin
2020-08-11 12:41 ` [PR PATCH] [Closed]: " leahneukirchen
2020-08-11 12:41 ` leahneukirchen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200811122328.pJCnLhYiJO3mwO0WXrQ0ztmaDZvliUBn0vFoXYMiN8E@z \
--to=duncaen@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).