Github messages for mblaze
 help / color / mirror / Atom feed
From: leahneukirchen <leahneukirchen@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [ISSUE] [CLOSED] fallback to $VISUAL
Date: Wed, 21 Apr 2021 15:10:55 +0200	[thread overview]
Message-ID: <20210421131055.c56JlFl_Oy9BxNvK6crN5EWi6txl5DEg47X_z85nooI@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-fa6558a0-26e0-48f6-803f-f5a8af34f6a8-mblaze-206@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 737 bytes --]

Closed issue by ndalliard on mblaze repository

https://github.com/leahneukirchen/mblaze/issues/206

Description:
I would suggest `EDITOR="${VISUAL:-${EDITOR:-vi}}"` in [mcom](https://github.com/leahneukirchen/mblaze/blob/e8981b723d35c530ef217140c965287ecd0e9031/mcom#L496) instead of only `${EDITOR:-vi}`.

On OpenBSD in `man ksh` it says under `EDITOR`:

````
                Note: traditionally, EDITOR was used to specify the name of
                an (old-style) line editor, such as ed(1), and VISUAL was
                used to specify a (new-style) screen editor, such as vi(1).
                Hence if VISUAL is set, it overrides EDITOR.
````

Can create a pull request if appreciated. Thanks for the great work!


      reply	other threads:[~2021-04-21 13:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-21 12:59 [ISSUE] " ndalliard
2021-04-21 13:10 ` leahneukirchen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210421131055.c56JlFl_Oy9BxNvK6crN5EWi6txl5DEg47X_z85nooI@z \
    --to=leahneukirchen@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).