* [ISSUE] fallback to $VISUAL
@ 2021-04-21 12:59 ndalliard
2021-04-21 13:10 ` [ISSUE] [CLOSED] " leahneukirchen
0 siblings, 1 reply; 2+ messages in thread
From: ndalliard @ 2021-04-21 12:59 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 734 bytes --]
New issue by ndalliard on mblaze repository
https://github.com/leahneukirchen/mblaze/issues/206
Description:
I would suggest `EDITOR="${VISUAL:-${EDITOR:-vi}}"` in [mcom](https://github.com/leahneukirchen/mblaze/blob/e8981b723d35c530ef217140c965287ecd0e9031/mcom#L496) instead of only `${EDITOR:-vi}`.
On OpenBSD in `man ksh` it says under `EDITOR`:
````
Note: traditionally, EDITOR was used to specify the name of
an (old-style) line editor, such as ed(1), and VISUAL was
used to specify a (new-style) screen editor, such as vi(1).
Hence if VISUAL is set, it overrides EDITOR.
````
Can create a pull request if appreciated. Thanks for the great work!
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [ISSUE] [CLOSED] fallback to $VISUAL
2021-04-21 12:59 [ISSUE] fallback to $VISUAL ndalliard
@ 2021-04-21 13:10 ` leahneukirchen
0 siblings, 0 replies; 2+ messages in thread
From: leahneukirchen @ 2021-04-21 13:10 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 737 bytes --]
Closed issue by ndalliard on mblaze repository
https://github.com/leahneukirchen/mblaze/issues/206
Description:
I would suggest `EDITOR="${VISUAL:-${EDITOR:-vi}}"` in [mcom](https://github.com/leahneukirchen/mblaze/blob/e8981b723d35c530ef217140c965287ecd0e9031/mcom#L496) instead of only `${EDITOR:-vi}`.
On OpenBSD in `man ksh` it says under `EDITOR`:
````
Note: traditionally, EDITOR was used to specify the name of
an (old-style) line editor, such as ed(1), and VISUAL was
used to specify a (new-style) screen editor, such as vi(1).
Hence if VISUAL is set, it overrides EDITOR.
````
Can create a pull request if appreciated. Thanks for the great work!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-21 13:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-21 12:59 [ISSUE] fallback to $VISUAL ndalliard
2021-04-21 13:10 ` [ISSUE] [CLOSED] " leahneukirchen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).