From: mbauhardt <mbauhardt@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: fixes leahneukirchen/mblaze#194
Date: Wed, 23 Mar 2022 09:10:14 +0100 [thread overview]
Message-ID: <20220323081014.3riuTVJeB9HUeSvgtMW4BrbGOVwAiL-5qW4AqGRy5Fg@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-fa6558a0-26e0-48f6-803f-f5a8af34f6a8-mblaze-223@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 543 bytes --]
New comment by mbauhardt on mblaze repository
https://github.com/leahneukirchen/mblaze/pull/223#issuecomment-1076060531
Comment:
> I don't think this will work, as we had the explicit cases exactly for 6 lines by default, you'd need to generalize the algorithm.
ah. ok. i see. you mean we have to do a loop around https://github.com/leahneukirchen/mblaze/pull/223/files#diff-0f549fd15ac39a405676bb080ab4f082f510f787923824ac807f07b45b86a8e3R30 ?
this make the thing a bit more complicated. i will take a closer look later this week.
prev parent reply other threads:[~2022-03-23 8:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-22 18:27 [PR PATCH] " mbauhardt
2022-03-22 18:34 ` leahneukirchen
2022-03-23 8:10 ` mbauhardt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220323081014.3riuTVJeB9HUeSvgtMW4BrbGOVwAiL-5qW4AqGRy5Fg@z \
--to=mbauhardt@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).