[PR PATCH] mcom: quote sequence for mbnc and mrep

[PR PATCH] mcom: quote sequence for mbnc and mrep

[codesoap]

[-- Attachment #1: Type: text/plain, Size: 585 bytes --]

There is a new pull request by codesoap against master on the mblaze repository

https://github.com/codesoap/mblaze master
https://github.com/leahneukirchen/mblaze/pull/231

mcom: quote sequence for mbnc and mrep
I was getting the "mrep: needs exactly one mail to reply to" error when trying to reply to messages, where the file was located in a directory with spaces. With this change, I was able to use `mrep` in such a case. I noticed the same code in `mbnc`, so I also applied the change there.

A patch file from https://github.com/leahneukirchen/mblaze/pull/231.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-231.patch --]
[-- Type: text/x-diff, Size: 744 bytes --]

From 4051d90ee5b6b0e5aa2b42d4d8c593fe935fbb39 Mon Sep 17 00:00:00 2001
From: codesoap <codesoap@mailbox.org>
Date: Wed, 9 Nov 2022 22:55:18 +0100
Subject: [PATCH] mcom: quote sequence for mbnc and mrep

---
 mcom | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/mcom b/mcom
index d60070e..2096282 100755
--- a/mcom
+++ b/mcom
@@ -321,7 +321,7 @@ fi
 		) fi
 		;;
 	*mbnc*)
-		set -- $(mseq -- "$@")
+		set -- "$(mseq -- "$@")"
 		if [ "$#" -ne 1 ]; then
 			printf 'mbnc: needs exactly one mail to bounce\n' 1>&2
 			exit 1
@@ -344,7 +344,7 @@ fi
 		)
 		;;
 	*mrep*)
-		set -- $(mseq -- "$@")
+		set -- "$(mseq -- "$@")"
 		if [ "$#" -ne 1 ]; then
 			printf 'mrep: needs exactly one mail to reply to\n' 1>&2
 			exit 1

Re: mcom: quote sequence for mbnc and mrep

[leahneukirchen]

[-- Attachment #1: Type: text/plain, Size: 279 bytes --]

New comment by leahneukirchen on mblaze repository

https://github.com/leahneukirchen/mblaze/pull/231#issuecomment-1309548605

Comment:
I think this should happen by setting IFS to newline instead, as else the warning is never triggered (and just another error occurs, I think.)

Re: [PR PATCH] [Updated] mcom: quote sequence for mbnc and mrep

[codesoap]

[-- Attachment #1: Type: text/plain, Size: 590 bytes --]

There is an updated pull request by codesoap against master on the mblaze repository

https://github.com/codesoap/mblaze master
https://github.com/leahneukirchen/mblaze/pull/231

mcom: quote sequence for mbnc and mrep
I was getting the "mrep: needs exactly one mail to reply to" error when trying to reply to messages, where the file was located in a directory with spaces. With this change, I was able to use `mrep` in such a case. I noticed the same code in `mbnc`, so I also applied the change there.

A patch file from https://github.com/leahneukirchen/mblaze/pull/231.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-231.patch --]
[-- Type: text/x-diff, Size: 805 bytes --]

From 29e943dacb01b3c76573373482b448a484387475 Mon Sep 17 00:00:00 2001
From: codesoap <codesoap@mailbox.org>
Date: Wed, 9 Nov 2022 22:55:18 +0100
Subject: [PATCH] mcom: allow spaces in sequence for mbnc and mrep

---
 mcom | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/mcom b/mcom
index d60070e..39171cb 100755
--- a/mcom
+++ b/mcom
@@ -321,7 +321,10 @@ fi
 		) fi
 		;;
 	*mbnc*)
-		set -- $(mseq -- "$@")
+		(
+			IFS=$NL
+			set -- $(mseq -- "$@")
+		)
 		if [ "$#" -ne 1 ]; then
 			printf 'mbnc: needs exactly one mail to bounce\n' 1>&2
 			exit 1
@@ -344,7 +347,10 @@ fi
 		)
 		;;
 	*mrep*)
-		set -- $(mseq -- "$@")
+		(
+			IFS=$NL
+			set -- $(mseq -- "$@")
+		)
 		if [ "$#" -ne 1 ]; then
 			printf 'mrep: needs exactly one mail to reply to\n' 1>&2
 			exit 1

Re: mcom: quote sequence for mbnc and mrep

[codesoap]

[-- Attachment #1: Type: text/plain, Size: 301 bytes --]

New comment by codesoap on mblaze repository

https://github.com/leahneukirchen/mblaze/pull/231#issuecomment-1309853308

Comment:
Oh, right, thanks for the correction. I've updated the commit. The error now occurs, when trying to reply to multiple e-mails, but not when a directory contains a space. 

Re: mcom: quote sequence for mbnc and mrep

[leahneukirchen]

[-- Attachment #1: Type: text/plain, Size: 235 bytes --]

New comment by leahneukirchen on mblaze repository

https://github.com/leahneukirchen/mblaze/pull/231#issuecomment-1311661888

Comment:
Unfortunately, `set` doesn't work inside `()`. I think you'll need to save and restore it instead.

Re: [PR PATCH] [Updated] mcom: quote sequence for mbnc and mrep

[codesoap]

[-- Attachment #1: Type: text/plain, Size: 590 bytes --]

There is an updated pull request by codesoap against master on the mblaze repository

https://github.com/codesoap/mblaze master
https://github.com/leahneukirchen/mblaze/pull/231

mcom: quote sequence for mbnc and mrep
I was getting the "mrep: needs exactly one mail to reply to" error when trying to reply to messages, where the file was located in a directory with spaces. With this change, I was able to use `mrep` in such a case. I noticed the same code in `mbnc`, so I also applied the change there.

A patch file from https://github.com/leahneukirchen/mblaze/pull/231.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-231.patch --]
[-- Type: text/x-diff, Size: 780 bytes --]

From 21a8308eac20e2506938d4b85ad47fd058933e98 Mon Sep 17 00:00:00 2001
From: codesoap <codesoap@mailbox.org>
Date: Wed, 9 Nov 2022 22:55:18 +0100
Subject: [PATCH] mcom: allow spaces in sequence for mbnc and mrep

---
 mcom | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/mcom b/mcom
index d60070e..fb48401 100755
--- a/mcom
+++ b/mcom
@@ -321,7 +321,10 @@ fi
 		) fi
 		;;
 	*mbnc*)
+		old_ifs="$IFS"
+		IFS=$NL
 		set -- $(mseq -- "$@")
+		IFS="$old_ifs"
 		if [ "$#" -ne 1 ]; then
 			printf 'mbnc: needs exactly one mail to bounce\n' 1>&2
 			exit 1
@@ -344,7 +347,10 @@ fi
 		)
 		;;
 	*mrep*)
+		old_ifs="$IFS"
+		IFS=$NL
 		set -- $(mseq -- "$@")
+		IFS="$old_ifs"
 		if [ "$#" -ne 1 ]; then
 			printf 'mrep: needs exactly one mail to reply to\n' 1>&2
 			exit 1

Re: mcom: quote sequence for mbnc and mrep

[codesoap]

[-- Attachment #1: Type: text/plain, Size: 248 bytes --]

New comment by codesoap on mblaze repository

https://github.com/leahneukirchen/mblaze/pull/231#issuecomment-1311733771

Comment:
Feels like I'm on the amateur hour over here. Sorry. I've updated the commit again. Hopefully it's correct this time.

Re: [PR PATCH] [Closed]: mcom: quote sequence for mbnc and mrep

[leahneukirchen]

[-- Attachment #1: Type: text/plain, Size: 445 bytes --]

There's a closed pull request on the mblaze repository

mcom: quote sequence for mbnc and mrep
https://github.com/leahneukirchen/mblaze/pull/231

Description:
I was getting the "mrep: needs exactly one mail to reply to" error when trying to reply to messages, where the file was located in a directory with spaces. With this change, I was able to use `mrep` in such a case. I noticed the same code in `mbnc`, so I also applied the change there.