Github messages for mblaze
 help / color / mirror / Atom feed
From: rakoo <>
Subject: Re: [PR PATCH] [Updated] Improve attachments handling
Date: Wed, 12 Apr 2023 16:45:34 +0200	[thread overview]
Message-ID: <20230412144534.I3ahRYfx4VMju9Rqxzs3IonN96DlV1nhlH5y2s57n98@z> (raw)
In-Reply-To: <>

[-- Attachment #1: Type: text/plain, Size: 624 bytes --]

There is an updated pull request by rakoo against master on the mblaze repository master

Improve attachments handling
I had to manually explore to understand how to add attachments, the man page was a bit evasive. It also didn't help that a `~` at the beginning of the path isn't caught, so I added the same treatment as outbox parsing.

Thanks for this fantastic piece of software, the joys of building one's own MUA in ~150 lines of shell scripts...

A patch file from is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-234.patch --]
[-- Type: text/x-diff, Size: 1454 bytes --]

From 307cb0a40b2b6a30af7b42bf850be735de9378c3 Mon Sep 17 00:00:00 2001
From: Matthieu Rakotojaona <>
Date: Mon, 27 Feb 2023 15:27:03 +0100
Subject: [PATCH 1/2] mcom: Allow tilde in attachment

 mcom | 1 +
 1 file changed, 1 insertion(+)

diff --git a/mcom b/mcom
index 397cb5f..7258266 100755
--- a/mcom
+++ b/mcom
@@ -84,6 +84,7 @@ do_mime() {
 			msed '/attach/d' "$draft"
 			for f in $(mhdr -M -h attach "$draft"); do
+				f=$(echo $f | sed "s:^~/:$HOME/:")
 				printf '#%s %s\n' \
 				       "$(file -Lb --mime "$f" | sed 's/ //g')" \

From 0d5395e934a0e86ba99481f5b18e3e0f28e703ce Mon Sep 17 00:00:00 2001
From: Matthieu Rakotojaona <>
Date: Mon, 27 Feb 2023 15:33:13 +0100
Subject: [PATCH 2/2] mcom: Document how attachments work

 man/mcom.1 | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/man/mcom.1 b/man/mcom.1
index 957c322..08592c7 100644
--- a/man/mcom.1
+++ b/man/mcom.1
@@ -130,6 +130,13 @@ Delete the draft and quit.
 Preview the draft, using
 .Xr mshow 1 .
+From within the editor, attachments are added by setting an Attach: header with the path to the desired files. Multiple Attach: headers can be added.
+To add from the commandline, use
+.Sq mcom Fl attach No path/to/file
+and the header will be added automatically.
+It is possible to use tilde (~) in the file path.
 .Bl -tag -width Ds

  parent reply	other threads:[~2023-04-12 14:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-27 14:39 [PR PATCH] " rakoo
2023-02-27 14:47 ` leahneukirchen
2023-04-12 14:45 ` rakoo [this message]
2023-05-23 22:47 ` Eolien55

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230412144534.I3ahRYfx4VMju9Rqxzs3IonN96DlV1nhlH5y2s57n98@z \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).