Github messages for mblaze
 help / color / mirror / Atom feed
From: thyssentishman <thyssentishman@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] Add Drafts profile key
Date: Thu, 22 Jun 2023 20:55:47 +0200	[thread overview]
Message-ID: <20230622185547.xyajnvhoQUv8nF9Uns3_Xt5xkCM1wVaDow0KPaAapZw@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-fa6558a0-26e0-48f6-803f-f5a8af34f6a8-mblaze-241@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 490 bytes --]

There is an updated pull request by thyssentishman against master on the mblaze repository

https://github.com/thyssentishman/mblaze master
https://github.com/leahneukirchen/mblaze/pull/241

Add Drafts profile key
Instead of saving drafts messages together with sent messages when the Outbox key is set in profile, allow the user to set a Drafts key to store them separately.

This commit closes #240 

A patch file from https://github.com/leahneukirchen/mblaze/pull/241.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-241.patch --]
[-- Type: text/x-diff, Size: 2696 bytes --]

From 64cfabec997a9cf6374bd8c24bab374be8351be1 Mon Sep 17 00:00:00 2001
From: Johannes Thyssen Tishman <johannes@thyssentishman.com>
Date: Thu, 22 Jun 2023 19:26:39 +0200
Subject: [PATCH] Add Drafts profile key

Allow the user to set a Drafts key in profile to store draft messages
and sent messages separately if Outbox is set.
---
 man/mblaze-profile.5 |  7 +++++--
 mcom                 | 14 ++++++++------
 2 files changed, 13 insertions(+), 8 deletions(-)

diff --git a/man/mblaze-profile.5 b/man/mblaze-profile.5
index 65d1b3d..fe58309 100644
--- a/man/mblaze-profile.5
+++ b/man/mblaze-profile.5
@@ -52,8 +52,11 @@ generation in
 .It Li Outbox\&:
 If set,
 .Xr mcom 1
-will create draft messages in this maildir,
-and save messages there after sending.
+will save messages in this maildir after sending.
+.It Li Drafts\&:
+If set,
+.Xr mcom 1
+will create draft messages in this maildir (defaults to Outbox). 
 .It Li Reply-From\&:
 A comma-separated list of display name and mail address pairs, formatted like this:
 .Dl Li Primary Name <myname1@domain1>, Name v.2 <myname2@domain2>, \[dq]Name, My Third\[dq] <myname3@domain3>, ...
diff --git a/mcom b/mcom
index 397cb5f..2cc4df5 100755
--- a/mcom
+++ b/mcom
@@ -236,7 +236,9 @@ esac
 hdrs="$(printf '%s\n' "${hdrs#$NL}" | mhdr -)"
 
 outbox=$(mhdr -h outbox "$MBLAZE/profile" | sed "s:^~/:$HOME/:")
-if [ -z "$outbox" ]; then
+draftbox=$(mhdr -h drafts "$MBLAZE/profile" | sed "s:^~/:$HOME/:")
+draftbox="${draftbox:-$outbox}"
+if [ -z "$draftbox" ]; then
 	if [ -z "$resume" ]; then
 		i=0
 		while [ -f "snd.$i" ]; do
@@ -249,13 +251,13 @@ if [ -z "$outbox" ]; then
 	draftmime="$draft.mime"
 else
 	if [ -z "$resume" ]; then
-		draft="$(true | mdeliver -v -c -XD "$outbox")"
+		draft="$(true | mdeliver -v -c -XD "$draftbox")"
 		if [ -z "$draft" ]; then
-			printf '%s\n' "$0: failed to create draft in outbox $outbox." 1>&2
+			printf '%s\n' "$0: failed to create draft in outbox $draftbox." 1>&2
 			exit 1
 		fi
 	elif [ -z "$draft" ]; then
-		draft=$(mlist -D "$outbox" | msort -r -M | sed 1q)
+		draft=$(mlist -D "$draftbox" | msort -r -M | sed 1q)
 	fi
 	draftmime="$(printf '%s\n' "$draft" | sed 's,\(.*\)/cur/,\1/tmp/mime-,')"
 fi
@@ -446,7 +448,7 @@ while :; do
 				if $sendmail <"$draftmime"; then
 					if [ "$outbox" ]; then
 						mv "$draftmime" "$draft"
-						mflag -d -S "$draft"
+						mrefile $(mflag -d -S "$draft") "$outbox"
 					else
 						rm "$draft" "$draftmime"
 					fi
@@ -464,7 +466,7 @@ while :; do
 				stampdate "$draft"
 				if $sendmail <"$draft"; then
 					if [ "$outbox" ]; then
-						mflag -d -S "$draft"
+						mrefile $(mflag -d -S "$draft") "$outbox"
 					else
 						rm "$draft"
 					fi

  parent reply	other threads:[~2023-06-22 18:55 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-22 17:31 [PR PATCH] " thyssentishman
2023-06-22 17:46 ` leahneukirchen
2023-06-22 18:55 ` thyssentishman [this message]
2023-06-22 19:03 ` thyssentishman
2023-06-22 19:37 ` leahneukirchen
2023-06-22 19:38 ` leahneukirchen
2023-06-22 20:15 ` [PR PATCH] [Merged]: " leahneukirchen
2023-06-23  6:56 ` thyssentishman
2023-06-23  6:58 ` thyssentishman
2023-06-23  8:00 ` thyssentishman
2023-06-23  8:00 ` thyssentishman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230622185547.xyajnvhoQUv8nF9Uns3_Xt5xkCM1wVaDow0KPaAapZw@z \
    --to=thyssentishman@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).