From: leahneukirchen <leahneukirchen@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: improve named part/attachment detection
Date: Fri, 11 Aug 2023 15:31:51 +0200 [thread overview]
Message-ID: <20230811133151.p2u4IOUq8cP3zlIEtbknO_ACTzZHDpwbZiosqMjeEpQ@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-fa6558a0-26e0-48f6-803f-f5a8af34f6a8-mblaze-232@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 325 bytes --]
New comment by leahneukirchen on mblaze repository
https://github.com/leahneukirchen/mblaze/pull/232#issuecomment-1674800830
Comment:
This looks good and probably is what we intended in the first place.
Please remove the spurious whitespace in one line, and if you can, add a test that checks all possible 4 situations.
next prev parent reply other threads:[~2023-08-11 13:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <gh-mailinglist-notifications-fa6558a0-26e0-48f6-803f-f5a8af34f6a8-mblaze-232@inbox.vuxu.org>
2023-02-12 10:38 ` ashiire
2023-08-11 11:37 ` ashiire
2023-08-11 13:31 ` leahneukirchen [this message]
2023-08-16 11:09 ` [PR PATCH] [Updated] " ashiire
2023-08-16 14:46 ` ashiire
2024-09-11 19:36 ` [PR PATCH] [Merged]: " leahneukirchen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230811133151.p2u4IOUq8cP3zlIEtbknO_ACTzZHDpwbZiosqMjeEpQ@z \
--to=leahneukirchen@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).