[PR PATCH] mcom: Document how attachments work

[PR PATCH] mcom: Document how attachments work

[rakoo]

[-- Attachment #1: Type: text/plain, Size: 423 bytes --]

There is a new pull request by rakoo against master on the mblaze repository

https://github.com/rakoo/mblaze doc-attachments
https://github.com/leahneukirchen/mblaze/pull/259

mcom: Document how attachments work
Reopening of https://github.com/leahneukirchen/mblaze/pull/234 with a proper branch that doesn't change as I fiddle with it

A patch file from https://github.com/leahneukirchen/mblaze/pull/259.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-doc-attachments-259.patch --]
[-- Type: text/x-diff, Size: 862 bytes --]

From ca6162a2c310b6eed648bd850de5da0552612c5b Mon Sep 17 00:00:00 2001
From: Matthieu Rakotojaona <m@rako.space>
Date: Mon, 27 Feb 2023 15:33:13 +0100
Subject: [PATCH] mcom: Document how attachments work

---
 man/mcom.1 | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/man/mcom.1 b/man/mcom.1
index 957c322..08592c7 100644
--- a/man/mcom.1
+++ b/man/mcom.1
@@ -130,6 +130,13 @@ Delete the draft and quit.
 Preview the draft, using
 .Xr mshow 1 .
 .El
+.Sh ATTACHMENTS
+From within the editor, attachments are added by setting an Attach: header with the path to the desired files. Multiple Attach: headers can be added.
+
+To add from the commandline, use
+.Sq mcom Fl attach No path/to/file
+and the header will be added automatically.
+It is possible to use tilde (~) in the file path.
 .Sh ENVIRONMENT
 .Bl -tag -width Ds
 .It Ev EDITOR , Ev VISUAL

Re: [PR PATCH] [Updated] mcom: Document how attachments work

[rakoo]

[-- Attachment #1: Type: text/plain, Size: 428 bytes --]

There is an updated pull request by rakoo against master on the mblaze repository

https://github.com/rakoo/mblaze doc-attachments
https://github.com/leahneukirchen/mblaze/pull/259

mcom: Document how attachments work
Reopening of https://github.com/leahneukirchen/mblaze/pull/234 with a proper branch that doesn't change as I fiddle with it

A patch file from https://github.com/leahneukirchen/mblaze/pull/259.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-doc-attachments-259.patch --]
[-- Type: text/x-diff, Size: 1891 bytes --]

From 76e5985c0c0c8c76cd7418b56c86158870265e8a Mon Sep 17 00:00:00 2001
From: Matthieu Rakotojaona <m@rako.space>
Date: Wed, 24 Apr 2024 18:47:46 +0200
Subject: [PATCH 1/2] contrib/mmailto: Fix using longer arguments

We put the args to $TERMINAL inside single quotes for terminals that want a single command,
and we put arguments extracted from the adress between double quotes to protect from spaces
---
 contrib/mmailto | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/contrib/mmailto b/contrib/mmailto
index 7feabb4..2b38def 100755
--- a/contrib/mmailto
+++ b/contrib/mmailto
@@ -19,7 +19,7 @@ fi
 IFS='
 '
 
-exec $TERMINAL -e mcom $(
+args=$(
 awk -v url="$1" '
 
 function decode(s) {
@@ -47,7 +47,7 @@ BEGIN {
     split(fields[i], kv, "=")
     if (kv[1] != "r") {
       args[length(args)+1] = "-" kv[1]
-      args[length(args)+1] =  kv[2]
+      args[length(args)+1] =  "\"" kv[2] "\""
     }
   }
   for (i in args) {
@@ -56,3 +56,5 @@ BEGIN {
 }
 '
 )
+
+exec $TERMINAL -e "mcom $args"

From 53a4b5995a4e03cb93589a813e8d1dd0617ac991 Mon Sep 17 00:00:00 2001
From: Matthieu Rakotojaona <m@rako.space>
Date: Mon, 27 Feb 2023 15:33:13 +0100
Subject: [PATCH 2/2] mcom: Document how attachments work

---
 man/mcom.1 | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/man/mcom.1 b/man/mcom.1
index 957c322..08592c7 100644
--- a/man/mcom.1
+++ b/man/mcom.1
@@ -130,6 +130,13 @@ Delete the draft and quit.
 Preview the draft, using
 .Xr mshow 1 .
 .El
+.Sh ATTACHMENTS
+From within the editor, attachments are added by setting an Attach: header with the path to the desired files. Multiple Attach: headers can be added.
+
+To add from the commandline, use
+.Sq mcom Fl attach No path/to/file
+and the header will be added automatically.
+It is possible to use tilde (~) in the file path.
 .Sh ENVIRONMENT
 .Bl -tag -width Ds
 .It Ev EDITOR , Ev VISUAL

Re: [PR PATCH] [Updated] mcom: Document how attachments work

[rakoo]

[-- Attachment #1: Type: text/plain, Size: 428 bytes --]

There is an updated pull request by rakoo against master on the mblaze repository

https://github.com/rakoo/mblaze doc-attachments
https://github.com/leahneukirchen/mblaze/pull/259

mcom: Document how attachments work
Reopening of https://github.com/leahneukirchen/mblaze/pull/234 with a proper branch that doesn't change as I fiddle with it

A patch file from https://github.com/leahneukirchen/mblaze/pull/259.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-doc-attachments-259.patch --]
[-- Type: text/x-diff, Size: 862 bytes --]

From f6bebed8b4a7fa358a06270dfaa7ea1a8f1d49e2 Mon Sep 17 00:00:00 2001
From: Matthieu Rakotojaona <m@rako.space>
Date: Mon, 27 Feb 2023 15:33:13 +0100
Subject: [PATCH] mcom: Document how attachments work

---
 man/mcom.1 | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/man/mcom.1 b/man/mcom.1
index 957c322..08592c7 100644
--- a/man/mcom.1
+++ b/man/mcom.1
@@ -130,6 +130,13 @@ Delete the draft and quit.
 Preview the draft, using
 .Xr mshow 1 .
 .El
+.Sh ATTACHMENTS
+From within the editor, attachments are added by setting an Attach: header with the path to the desired files. Multiple Attach: headers can be added.
+
+To add from the commandline, use
+.Sq mcom Fl attach No path/to/file
+and the header will be added automatically.
+It is possible to use tilde (~) in the file path.
 .Sh ENVIRONMENT
 .Bl -tag -width Ds
 .It Ev EDITOR , Ev VISUAL

Re: mcom: Document how attachments work

[thimc]

[-- Attachment #1: Type: text/plain, Size: 562 bytes --]

New comment by thimc on mblaze repository

https://github.com/leahneukirchen/mblaze/pull/259#issuecomment-2336619596

Comment:
We may as well document that it is possible to attach files using the provided syntax in mmime(1):

`#content/type[#content-disposition] path[>filename]`

The only issue with this type of attachment is that the tilde does not seem to be supported and that you are forced to specify the MIME. So perhaps it is worth noting that if adding a Attach header is not what you want for whatever reason one could refer to the mmime manual?