Github messages for mblaze
 help / color / mirror / Atom feed
From: jeremybobbin <jeremybobbin@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] seq: fix infinite loop when selecting thread of orphaned message
Date: Mon, 10 Aug 2020 22:12:44 +0200	[thread overview]
Message-ID: <gh-mailinglist-notifications-fa6558a0-26e0-48f6-803f-f5a8af34f6a8-mblaze-180@inbox.vuxu.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 421 bytes --]

There is a new pull request by jeremybobbin against master on the mblaze repository

https://github.com/jeremybobbin/mblaze master
https://github.com/leahneukirchen/mblaze/pull/180

seq: fix infinite loop when selecting thread of orphaned message
To replicate the infinite loop:

```
printf ' a\n' | mseq -S
mseq .=
```

Thanks

A patch file from https://github.com/leahneukirchen/mblaze/pull/180.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-180.patch --]
[-- Type: text/x-diff, Size: 722 bytes --]

From 2812bebb5bc1d07e8f001d3347a36f2c34d88573 Mon Sep 17 00:00:00 2001
From: Jeremy Bobbin <jer@jer.cx>
Date: Mon, 10 Aug 2020 12:55:16 -0700
Subject: [PATCH] seq: fix infinite loop when selecting thread of orphaned
 message

printf ' a\n' | mseq -S
mseq .=
---
 seq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/seq.c b/seq.c
index 970e30b..a75ee3f 100644
--- a/seq.c
+++ b/seq.c
@@ -427,7 +427,7 @@ blaze822_seq_next(char *map, char *range, struct blaze822_seq_iter *iter)
 	if (!iter->lines)  // count total lines
 		find_cur(map, iter);
 
-	if (!iter->start) {
+	if (!iter->s) {
 		int ret = parse_range(map, range, &iter->start, &iter->stop,
 		    iter->cur, iter->lines);
 		if (ret == 1) {

             reply	other threads:[~2020-08-10 20:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-10 20:12 jeremybobbin [this message]
2020-08-10 20:23 ` leahneukirchen
2020-08-10 20:23 ` [PR PATCH] [Closed]: " leahneukirchen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=gh-mailinglist-notifications-fa6558a0-26e0-48f6-803f-f5a8af34f6a8-mblaze-180@inbox.vuxu.org \
    --to=jeremybobbin@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    --subject='Re: [PR PATCH] seq: fix infinite loop when selecting thread of orphaned message' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).