Github messages for mblaze
 help / color / mirror / Atom feed
* [PR PATCH] mcom: allow tilde prefixed path for profile's outbox setting
@ 2020-10-08 10:27 JNRowe
  2020-10-08 10:46 ` leahneukirchen
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: JNRowe @ 2020-10-08 10:27 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 318 bytes --]

There is a new pull request by JNRowe against master on the mblaze repository

https://github.com/JNRowe/mblaze master
https://github.com/leahneukirchen/mblaze/pull/187

mcom: allow tilde prefixed path for profile's outbox setting


A patch file from https://github.com/leahneukirchen/mblaze/pull/187.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-187.patch --]
[-- Type: text/x-diff, Size: 614 bytes --]

From 196224321143a666bd6d2a9dd69779430cf2e24d Mon Sep 17 00:00:00 2001
From: James Rowe <jnrowe@gmail.com>
Date: Thu, 8 Oct 2020 11:25:45 +0100
Subject: [PATCH] mcom: allow tilde prefixed path for profile's outbox setting

---
 mcom | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mcom b/mcom
index a1a1f90..246f51f 100755
--- a/mcom
+++ b/mcom
@@ -231,7 +231,7 @@ esac
 
 hdrs="$(printf '%s\n' "${hdrs#$NL}" | mhdr -)"
 
-outbox=$(mhdr -h outbox "$MBLAZE/profile")
+outbox=$(mhdr -h outbox "$MBLAZE/profile" | sed "s,^~/,$HOME/,")
 if [ -z "$outbox" ]; then
 	if [ -z "$resume" ]; then
 		i=0

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: mcom: allow tilde prefixed path for profile's outbox setting
  2020-10-08 10:27 [PR PATCH] mcom: allow tilde prefixed path for profile's outbox setting JNRowe
@ 2020-10-08 10:46 ` leahneukirchen
  2020-10-08 11:42 ` [PR PATCH] [Updated] " JNRowe
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: leahneukirchen @ 2020-10-08 10:46 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 228 bytes --]

New comment by leahneukirchen on mblaze repository

https://github.com/leahneukirchen/mblaze/pull/187#issuecomment-705488810

Comment:
Thanks. Please use `:` instead of `,` in the sed, Unix home dirs can not really contain `:`.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR PATCH] [Updated] mcom: allow tilde prefixed path for profile's outbox setting
  2020-10-08 10:27 [PR PATCH] mcom: allow tilde prefixed path for profile's outbox setting JNRowe
  2020-10-08 10:46 ` leahneukirchen
@ 2020-10-08 11:42 ` JNRowe
  2020-10-08 11:43 ` JNRowe
  2020-10-08 12:27 ` [PR PATCH] [Closed]: " leahneukirchen
  3 siblings, 0 replies; 5+ messages in thread
From: JNRowe @ 2020-10-08 11:42 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 523 bytes --]

There is an updated pull request by JNRowe against master on the mblaze repository

https://github.com/JNRowe/mblaze master
https://github.com/leahneukirchen/mblaze/pull/187

mcom: allow tilde prefixed path for profile's outbox setting
I assumed – perhaps incorrectly – that my `outbox` setting could be `~/Mail/Sent`.  However, doing so fails because the tilde isn’t expanded.  This trivial change fixes that.

Thanks,

James

A patch file from https://github.com/leahneukirchen/mblaze/pull/187.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-187.patch --]
[-- Type: text/x-diff, Size: 614 bytes --]

From d114af08c9405eda32d28daf1e5185e8a41f2cb1 Mon Sep 17 00:00:00 2001
From: James Rowe <jnrowe@gmail.com>
Date: Thu, 8 Oct 2020 11:25:45 +0100
Subject: [PATCH] mcom: allow tilde prefixed path for profile's outbox setting

---
 mcom | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mcom b/mcom
index a1a1f90..7bb3ce6 100755
--- a/mcom
+++ b/mcom
@@ -231,7 +231,7 @@ esac
 
 hdrs="$(printf '%s\n' "${hdrs#$NL}" | mhdr -)"
 
-outbox=$(mhdr -h outbox "$MBLAZE/profile")
+outbox=$(mhdr -h outbox "$MBLAZE/profile" | sed "s:^~/:$HOME/:")
 if [ -z "$outbox" ]; then
 	if [ -z "$resume" ]; then
 		i=0

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: mcom: allow tilde prefixed path for profile's outbox setting
  2020-10-08 10:27 [PR PATCH] mcom: allow tilde prefixed path for profile's outbox setting JNRowe
  2020-10-08 10:46 ` leahneukirchen
  2020-10-08 11:42 ` [PR PATCH] [Updated] " JNRowe
@ 2020-10-08 11:43 ` JNRowe
  2020-10-08 12:27 ` [PR PATCH] [Closed]: " leahneukirchen
  3 siblings, 0 replies; 5+ messages in thread
From: JNRowe @ 2020-10-08 11:43 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 371 bytes --]

New comment by JNRowe on mblaze repository

https://github.com/leahneukirchen/mblaze/pull/187#issuecomment-705514149

Comment:
> Thanks. Please use `:` instead of `,` in the sed, Unix home dirs can not really contain `:`.

Fixed.  I'll note that I noodled on the separator for a little while before making my commit, but simply couldn't figure out a truly valid one ;)

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR PATCH] [Closed]: mcom: allow tilde prefixed path for profile's outbox setting
  2020-10-08 10:27 [PR PATCH] mcom: allow tilde prefixed path for profile's outbox setting JNRowe
                   ` (2 preceding siblings ...)
  2020-10-08 11:43 ` JNRowe
@ 2020-10-08 12:27 ` leahneukirchen
  3 siblings, 0 replies; 5+ messages in thread
From: leahneukirchen @ 2020-10-08 12:27 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 382 bytes --]

There's a closed pull request on the mblaze repository

mcom: allow tilde prefixed path for profile's outbox setting
https://github.com/leahneukirchen/mblaze/pull/187

Description:
I assumed – perhaps incorrectly – that my `outbox` setting could be `~/Mail/Sent`.  However, doing so fails because the tilde isn’t expanded.  This trivial change fixes that.

Thanks,

James

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-10-08 12:27 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-08 10:27 [PR PATCH] mcom: allow tilde prefixed path for profile's outbox setting JNRowe
2020-10-08 10:46 ` leahneukirchen
2020-10-08 11:42 ` [PR PATCH] [Updated] " JNRowe
2020-10-08 11:43 ` JNRowe
2020-10-08 12:27 ` [PR PATCH] [Closed]: " leahneukirchen

Github messages for mblaze

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.vuxu.org/mblaze-github

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 mblaze-github mblaze-github/ http://inbox.vuxu.org/mblaze-github \
		mblaze-github@inbox.vuxu.org
	public-inbox-index mblaze-github

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.github.mblaze


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git