From: gco <gco@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] use -fstack-protector-strong for both compiling and linking
Date: Sat, 11 Jun 2022 05:17:24 +0200 [thread overview]
Message-ID: <gh-mailinglist-notifications-fa6558a0-26e0-48f6-803f-f5a8af34f6a8-mblaze-229@inbox.vuxu.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 448 bytes --]
There is a new pull request by gco against master on the mblaze repository
https://github.com/gco/mblaze stackprot
https://github.com/leahneukirchen/mblaze/pull/229
use -fstack-protector-strong for both compiling and linking
gcc needs -fstack-protector-strong when linking else `__stack_chk_fail` and `__stack_chk_guard` are not defined (at least on Solaris).
A patch file from https://github.com/leahneukirchen/mblaze/pull/229.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-stackprot-229.patch --]
[-- Type: text/x-diff, Size: 615 bytes --]
From 35441478ad3bdc63c569c9f432b6e3e5df20026d Mon Sep 17 00:00:00 2001
From: gco <gco@jazzhaiku.com>
Date: Fri, 10 Jun 2022 20:08:40 -0700
Subject: [PATCH] if -fstack-protector-strong is used, it needs to be specified
for both compiling and linking
---
GNUmakefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/GNUmakefile b/GNUmakefile
index 07a0b1a..c90e938 100644
--- a/GNUmakefile
+++ b/GNUmakefile
@@ -1,5 +1,6 @@
CFLAGS?=-g -O2 -fstack-protector-strong -D_FORTIFY_SOURCE=2
override CFLAGS:=-Wall -Wno-switch -Wextra $(CFLAGS)
+LDFLAGS?=-fstack-protector-strong
LDLIBS=-lrt
OS := $(shell uname)
next reply other threads:[~2022-06-11 3:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-11 3:17 gco [this message]
2022-06-18 21:07 ` [PR PATCH] [Closed]: " leahneukirchen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=gh-mailinglist-notifications-fa6558a0-26e0-48f6-803f-f5a8af34f6a8-mblaze-229@inbox.vuxu.org \
--to=gco@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).