Github messages for mblaze
 help / color / mirror / Atom feed
From: xelxebar <xelxebar@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [ISSUE] mrep: Use first instead of last delivered-to to set from address 
Date: Sun, 12 Feb 2023 13:25:34 +0100	[thread overview]
Message-ID: <gh-mailinglist-notifications-fa6558a0-26e0-48f6-803f-f5a8af34f6a8-mblaze-233@inbox.vuxu.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 1300 bytes --]

New issue by xelxebar on mblaze repository

https://github.com/leahneukirchen/mblaze/issues/233

Description:
## Overview

Commit e1e5bfe5 introduces a regression against 282de650. In cases where there are multiple `Delivered-To` headers, it is most likely that we want `mrep` to populate the sender address from the most public-facing `Delivered-To`, *i.e.* the first one; however, at the moment we are setting it to the address in the final (*i.e.* topmost and most internal-facing) one.

## Why?

We have a posix setup that aliases multiple addresses into a virtual mailbox---*e.g.* all mails going to `mars.*@example.com` get glommed into `mars@example.com`. The problem is that postfix aliases end up adding an additional `Delivered-To` header for each of these alias redirections. This is necessary to detect alias loops and related problems.

## Patch points

This proposed change boils down to munging [mcom:377](https://github.com/leahneukirchen/mblaze/blob/master/mcom#L377). I believe we just need to reverse the order of headers passed to `maddr` and then `tail -n 1` instead of `head -n 1`. However, it appears that `maddr` doesn't currently have a `-M` switch like `mhdr`, so maybe a patch there is needed as well?

## Comments

Thoughts? Does the above sound reasonable?

             reply	other threads:[~2023-02-12 12:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-12 12:25 xelxebar [this message]
2023-05-01  4:43 ` xelxebar
2023-05-01  8:41 ` stacyharper
2023-05-01 14:05 ` leahneukirchen
2023-05-01 14:07 ` leahneukirchen
2023-10-27  8:20 ` Anachron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=gh-mailinglist-notifications-fa6558a0-26e0-48f6-803f-f5a8af34f6a8-mblaze-233@inbox.vuxu.org \
    --to=xelxebar@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).