From: rakoo <rakoo@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] contrib/mmailto: Fix using longer arguments
Date: Wed, 24 Apr 2024 19:05:59 +0200 [thread overview]
Message-ID: <gh-mailinglist-notifications-fa6558a0-26e0-48f6-803f-f5a8af34f6a8-mblaze-258@inbox.vuxu.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 564 bytes --]
There is a new pull request by rakoo against master on the mblaze repository
https://github.com/rakoo/mblaze master
https://github.com/leahneukirchen/mblaze/pull/258
contrib/mmailto: Fix using longer arguments
We put the args to $TERMINAL inside single quotes for terminals that want a single command, and we put arguments extracted from the adress between double quotes to protect from spaces.
This is necessary for `xfce4-terminal` for example, and doesn't break `xterm`
A patch file from https://github.com/leahneukirchen/mblaze/pull/258.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-258.patch --]
[-- Type: text/x-diff, Size: 1020 bytes --]
From 601189ea2c1d64a86f1851739254494c74c25416 Mon Sep 17 00:00:00 2001
From: Matthieu Rakotojaona <m@rako.space>
Date: Wed, 24 Apr 2024 18:47:46 +0200
Subject: [PATCH] contrib/mmailto: Fix using longer arguments
We put the args to $TERMINAL inside single quotes for terminals that want a single command,
and we put arguments extracted from the adress between double quotes to protect from spaces
---
contrib/mmailto | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/contrib/mmailto b/contrib/mmailto
index 7feabb4..2b38def 100755
--- a/contrib/mmailto
+++ b/contrib/mmailto
@@ -19,7 +19,7 @@ fi
IFS='
'
-exec $TERMINAL -e mcom $(
+args=$(
awk -v url="$1" '
function decode(s) {
@@ -47,7 +47,7 @@ BEGIN {
split(fields[i], kv, "=")
if (kv[1] != "r") {
args[length(args)+1] = "-" kv[1]
- args[length(args)+1] = kv[2]
+ args[length(args)+1] = "\"" kv[2] "\""
}
}
for (i in args) {
@@ -56,3 +56,5 @@ BEGIN {
}
'
)
+
+exec $TERMINAL -e "mcom $args"
next reply other threads:[~2024-04-24 17:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 17:05 rakoo [this message]
2024-06-06 11:12 ` [PR PATCH] [Updated] " rakoo
2024-06-06 11:25 ` rakoo
2024-09-05 12:13 ` rakoo
2024-09-11 19:48 ` leahneukirchen
2024-09-11 23:13 ` rakoo
2024-09-12 11:39 ` leahneukirchen
2024-09-12 12:10 ` rakoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=gh-mailinglist-notifications-fa6558a0-26e0-48f6-803f-f5a8af34f6a8-mblaze-258@inbox.vuxu.org \
--to=rakoo@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).