From: rakoo <rakoo@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] Fix typo in reading body from arg
Date: Mon, 17 Jun 2024 23:46:15 +0200 [thread overview]
Message-ID: <gh-mailinglist-notifications-fa6558a0-26e0-48f6-803f-f5a8af34f6a8-mblaze-260@inbox.vuxu.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 599 bytes --]
There is a new pull request by rakoo against master on the mblaze repository
https://github.com/rakoo/mblaze body-arg
https://github.com/leahneukirchen/mblaze/pull/260
Fix typo in reading body from arg
When given a body argument like this:
```
mcom foo@bar -body "this is my body"
```
the body isn't taken into account. This is because we try to `cat` from a file called "this is my body", instead of doing a process substitution for a file that fake-contains "this is my body". I believe it is a typo.
A patch file from https://github.com/leahneukirchen/mblaze/pull/260.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-body-arg-260.patch --]
[-- Type: text/x-diff, Size: 561 bytes --]
From 98f76924d81b025596e881cfe5b87fd5c1b6bd45 Mon Sep 17 00:00:00 2001
From: Matthieu Rakotojaona <m@rako.space>
Date: Mon, 17 Jun 2024 23:42:16 +0200
Subject: [PATCH] mcom: fix reading from body given in arg
---
mcom | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mcom b/mcom
index 4e834c6..28f1ddf 100755
--- a/mcom
+++ b/mcom
@@ -287,7 +287,7 @@ fi
printf '\n'
(
IFS=$NL
- cat -- /dev/null $(printf '%s' "$hdrs" | mhdr -M -h body -)
+ cat -- /dev/null <(printf '%s' "$hdrs" | mhdr -M -h body -)
)
printf '\n'
;;
next reply other threads:[~2024-06-17 21:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-17 21:46 rakoo [this message]
2024-06-18 19:01 ` [PR PATCH] [Closed]: " leahneukirchen
2024-06-18 19:01 ` leahneukirchen
2024-06-18 19:51 ` rakoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=gh-mailinglist-notifications-fa6558a0-26e0-48f6-803f-f5a8af34f6a8-mblaze-260@inbox.vuxu.org \
--to=rakoo@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).