From: Laine Gholson <laine.gholson@gmail.com>
To: musl@lists.openwall.com
Subject: [PATCH] configure: check whether linker works too
Date: Mon, 24 Oct 2016 18:05:02 -0500 [thread overview]
Message-ID: <004a5919-eb25-d4bf-a680-57049fa4d428@gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 348 bytes --]
As a result of http://www.openwall.com/lists/musl/2016/10/22/3
it has been shown that musl's current compiler sanity checks
are inadequate. This patch checks if the compiler as a whole
works properly, and moves the CPPFLAGS/CFLAGS/LDFLAGS sanity
checks after the 'compiler works' check.
Patch and patch signature attached
Thanks,
Laine Gholson
[-- Attachment #2: configure.patch --]
[-- Type: text/x-patch, Size: 1159 bytes --]
From 99fd54d6f2b7c84a02c1ca0d5f1397d709c14313 Mon Sep 17 00:00:00 2001
From: Laine Gholson <laine.gholson@gmail.com>
Date: Mon, 24 Oct 2016 17:49:58 -0500
Subject: [PATCH] configure: check whether linker works too
and move flag sanity checks to a seperate test
---
configure | 13 +++++++++++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/configure b/configure
index 707eb12..e7d565c 100755
--- a/configure
+++ b/configure
@@ -236,8 +236,17 @@ printf "%s\n" "$CC"
test -n "$CC" || { echo "$0: cannot find a C compiler" ; exit 1 ; }
printf "checking whether C compiler works... "
-echo "typedef int x;" > "$tmpc"
-if output=$($CC $CPPFLAGS $CFLAGS -c -o /dev/null "$tmpc" 2>&1) ; then
+echo 'int main(void) { return 0; }' > "$tmpc"
+if output=$($CC -o /dev/null "$tmpc" 2>&1) ; then
+printf "yes\n"
+else
+printf "no; compiler output follows:\n%s\n" "$output"
+exit 1
+fi
+
+printf 'checking whether *FLAGS are sane... '
+echo 'int main(void) { return 0; }' > "$tmpc"
+if output=$($CC $CFLAGS $CPPFLAGS $LDFLAGS -o /dev/null "$tmpc" 2>&1) ; then
printf "yes\n"
else
printf "no; compiler output follows:\n%s\n" "$output"
--
2.10.1
[-- Attachment #3: configure.patch.asc --]
[-- Type: text/plain, Size: 801 bytes --]
-----BEGIN PGP SIGNATURE-----
iQIcBAABCgAGBQJYDpFPAAoJEK8T7CzTdRCcPzAP/RRxjdB7h3OhXEI2t+4Y5Ves
ih45z3NtcMgdgcR8UgCOj4nsknR4TxkeuzO3tlpdALTeZPiLBRvUZj1GqPThq6PG
N3b95fwRD6lbDE546QRZ2yy+CwRZtr8fqBPud8J+L9PgvUuN24tKMwuv6uK7xkwU
1CLAS05gvBRbooOb0aq+9v2blcigJvEZdJL9a7SJweSBCQJ1k0HAln9JNg4QPQBr
71/Vp+EsvB6CPf4JJjsW9gCdUgbapUZ4e+Crrb616EzPDrBbu+QRbOcWcBtXzFlg
qssPQB3qyVzMKt49mDxrlSSAr0hPzgV1520ODEdZbgKKA0NcyVthhWzHxQ5cDfai
+h4FhnCO20WZ1KiBRM5P5DdUFSaXE94Gg/NIih+aOo+y3uznLLrw1fb+byzPGhgy
U1dHywKwaq4QTRYbuJ6FhSqoc5GqPNJzKDg9wkibOdYEGQ9Z3hv6j273Wa1fEnfT
WYlh1grDtjpa5LmdI4jRuo6YD8uyEHiKP6NNMZQFZOA7tqt2C1/2/7wSmXzAk/JK
NRWzFY4bCRuTCHXQbyJjMyLHj726fKLb7GN+e2lPx9MF8amU+MdU16riFEPPeYj0
2HRvlijJ3Fai9QmIJlipHPyAFTxp1ET2paGwwTPcNZHVOyuS40ckLVEFJ6g06BPP
isrOCBx9mZkGLkd2ztnh
=4mAJ
-----END PGP SIGNATURE-----
next reply other threads:[~2016-10-24 23:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-24 23:05 Laine Gholson [this message]
2016-10-24 23:23 ` Rich Felker
2016-10-25 0:00 ` Laine Gholson
2016-10-25 9:13 ` Szabolcs Nagy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=004a5919-eb25-d4bf-a680-57049fa4d428@gmail.com \
--to=laine.gholson@gmail.com \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).