From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/10667 Path: news.gmane.org!.POSTED!not-for-mail From: Laine Gholson Newsgroups: gmane.linux.lib.musl.general Subject: [PATCH] configure: check whether linker works too Date: Mon, 24 Oct 2016 18:05:02 -0500 Message-ID: <004a5919-eb25-d4bf-a680-57049fa4d428@gmail.com> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------1CD05B8B992065A762953181" X-Trace: blaine.gmane.org 1477350340 25586 195.159.176.226 (24 Oct 2016 23:05:40 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 24 Oct 2016 23:05:40 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux armv7l; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 To: musl@lists.openwall.com Original-X-From: musl-return-10680-gllmg-musl=m.gmane.org@lists.openwall.com Tue Oct 25 01:05:32 2016 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.84_2) (envelope-from ) id 1byoIy-0004Kh-U9 for gllmg-musl@m.gmane.org; Tue, 25 Oct 2016 01:05:20 +0200 Original-Received: (qmail 7794 invoked by uid 550); 24 Oct 2016 23:05:20 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 7762 invoked from network); 24 Oct 2016 23:05:18 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=to:from:subject:message-id:date:user-agent:mime-version; bh=jdqd91jesF89cLxqmGeX3tmIQIRhxg9/Y3xdDtIYh/Q=; b=RP+FhIyH6Zo13c5JYfv7XjOAQtK7lgjUVm5a2RE24sSdkW3FBjvEJ8GjSaw1ic4UxD JpenClaUmLphqgRcPPPHeenGmAC7+rvPC/dJ07J5+KoIs4iSEQKORnHshu0cw5sIUYHp HFUUP1vOP9heGK+eG1lhqH1hPAgV+jU/FlN4Bwa6y3WgrZNLmxb9j2b5e+fH5KmR2dCX ixPHPob1SQPuLx6GitVcdRlTf+9X9vF/+H8DU0YVe2t5sAEXz8rO/TO3Y17TAJFlXkpg O8cXkkr7ljxY8o8ifvXkBgdTRHVY6bCs0ToGZRLL6blpgFIMNUdJNy8SPCqvsHnEs+7o T3KQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:to:from:subject:message-id:date:user-agent :mime-version; bh=jdqd91jesF89cLxqmGeX3tmIQIRhxg9/Y3xdDtIYh/Q=; b=WT/YrAfPePkKEHkZGsUAA0KPfQJVG9kYxIIFI/vrilMrKujiHWI79GYR9am1uZABAK XKkNiDo67AdV1ZRJol3hv3gu4Mt/4Nlj8QECko5iO1mBeIcB5cX9f5njUaVwPme3ZZ6P 8dnvkyJPUYIrA1D0PWFUN/Aj7/wM/9MZHAmEslRpKXCYOdGRotizxciim6oA6YieH6U1 uL6zNAgg+DO9vrJfw0iXxQP4ehqeRlT1iDPCP7HHwypCsTczFyoXZGDDL1RGrzZAX9Vx zphkw4CFvEofLvXo9RIAaiLMIXRIkIrXNw+xiHcxKPs0aSPMTbCUDsDO4RBWck9BnGLs lxJQ== X-Gm-Message-State: ABUngvf0HyAGNbzdyEVhTiCFWbsr2j6tnstWA6ZXMOkzA9gFoSmlBIi5p/AtWbvY0bCtCA== X-Received: by 10.36.75.139 with SMTP id q133mr59058ita.116.1477350306033; Mon, 24 Oct 2016 16:05:06 -0700 (PDT) Xref: news.gmane.org gmane.linux.lib.musl.general:10667 Archived-At: This is a multi-part message in MIME format. --------------1CD05B8B992065A762953181 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit As a result of http://www.openwall.com/lists/musl/2016/10/22/3 it has been shown that musl's current compiler sanity checks are inadequate. This patch checks if the compiler as a whole works properly, and moves the CPPFLAGS/CFLAGS/LDFLAGS sanity checks after the 'compiler works' check. Patch and patch signature attached Thanks, Laine Gholson --------------1CD05B8B992065A762953181 Content-Type: text/x-patch; name="configure.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="configure.patch" >From 99fd54d6f2b7c84a02c1ca0d5f1397d709c14313 Mon Sep 17 00:00:00 2001 From: Laine Gholson Date: Mon, 24 Oct 2016 17:49:58 -0500 Subject: [PATCH] configure: check whether linker works too and move flag sanity checks to a seperate test --- configure | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 707eb12..e7d565c 100755 --- a/configure +++ b/configure @@ -236,8 +236,17 @@ printf "%s\n" "$CC" test -n "$CC" || { echo "$0: cannot find a C compiler" ; exit 1 ; } printf "checking whether C compiler works... " -echo "typedef int x;" > "$tmpc" -if output=$($CC $CPPFLAGS $CFLAGS -c -o /dev/null "$tmpc" 2>&1) ; then +echo 'int main(void) { return 0; }' > "$tmpc" +if output=$($CC -o /dev/null "$tmpc" 2>&1) ; then +printf "yes\n" +else +printf "no; compiler output follows:\n%s\n" "$output" +exit 1 +fi + +printf 'checking whether *FLAGS are sane... ' +echo 'int main(void) { return 0; }' > "$tmpc" +if output=$($CC $CFLAGS $CPPFLAGS $LDFLAGS -o /dev/null "$tmpc" 2>&1) ; then printf "yes\n" else printf "no; compiler output follows:\n%s\n" "$output" -- 2.10.1 --------------1CD05B8B992065A762953181 Content-Type: text/plain; charset=UTF-8; name="configure.patch.asc" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="configure.patch.asc" LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0KCmlRSWNCQUFCQ2dBR0JRSllEcEZQQUFv SkVLOFQ3Q3pUZFJDY1B6QVAvUlJ4amRCN2gzT2hYRUkydCs0WTVWZXMKaWg0NXozTnRjTWdk Z2NSOFVnQ09qNG5za25SNFR4a2V1ek8zdGxwZEFMVGVaUGlMQlJ2VVpqMUdxUFRocTZQRwpO M2I5NWZ3UkQ2bGJERTU0NlFSWjJ5eStDd1JadHI4ZnFCUHVkOEorTDlQZ3ZVdU4yNHRLTXd1 djZ1Szd4a3dVCjFDTEFTMDVndkJSYm9vT2IwYXErOXYyYmxjaWdKdkVaZEpMOWE3U0p3ZVNC Q1FKMWswSEFsbjlKTmc0UVBRQnIKNzEvVnArRXN2QjZDUGY0Skpqc1c5Z0NkVWdiYXBVWjRl K0NycmI2MTZFelBEckJidStRUmJPY1djQnRYekZsZwpxc3NQUUIzcXlWek1LdDQ5bUR4cmxT U0FyMGhQemdWMTUyME9ERWRaYmdLS0EwTmN5VnRoaFd6SHhRNWNEZmFpCitoNEZobkNPMjBX WjFLaUJSTTVQNURkVUZTYVhFOTRHZy9OSWloK2FPbyt5M3V6bkxMcncxZmIrYnl6UEdoZ3kK VTFkSHl3S3dhcTRRVFJZYnVKNkZoU3FvYzVHcVBOSnpLRGc5d2tpYk9kWUVHUTlaM2h2Nmoy NzNXYTFmRW5mVApXWWxoMWdyRHRqcGE1TG1kSTRqUnVvNllEOHV5RUhpS1A2Tk5NWlFGWk9B N3RxdDJDMS8yLzd3U21YekFrL0pLCk5SV3pGWTRiQ1J1VENIWFFieUpqTXlMSGo3MjZmS0xi N0dOK2UybFB4OU1GOGFtVStNZFUxNnJpRkVQUGVZajAKMkhSdmxpakozRmFpOVFtSUpsaXBI UHlBRlR4cDFFVDJwYUd3d1RQY05aSFZPeXVTNDBja0xWRUZKNmcwNkJQUAppc3JPQ0J4OW1a a0dMa2QyenRuaAo9NG1BSgotLS0tLUVORCBQR1AgU0lHTkFUVVJFLS0tLS0K --------------1CD05B8B992065A762953181--