From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/9811 Path: news.gmane.org!not-for-mail From: Sebastian Gottschall Newsgroups: gmane.linux.lib.musl.general Subject: Re: recvmsg/sendmsg broken on mips64 Date: Fri, 1 Apr 2016 12:29:35 +0200 Message-ID: <02844173-9671-d0e9-a291-764b27899f44@dd-wrt.com> References: <20160331192518.GW21636@brightrain.aerifal.cx> <20160331201012.GR9862@port70.net> <20160331203004.GX21636@brightrain.aerifal.cx> <76c20e67-4d62-a929-9f1d-a3fc63758426@dd-wrt.com> <20160401094919.GT9862@port70.net> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1459507537 26054 80.91.229.3 (1 Apr 2016 10:45:37 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 1 Apr 2016 10:45:37 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-9824-gllmg-musl=m.gmane.org@lists.openwall.com Fri Apr 01 12:45:26 2016 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1alwZu-0004Mj-Pk for gllmg-musl@m.gmane.org; Fri, 01 Apr 2016 12:45:22 +0200 Original-Received: (qmail 23605 invoked by uid 550); 1 Apr 2016 10:45:20 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 23578 invoked from network); 1 Apr 2016 10:45:19 -0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dd-wrt.com; s=mikd; h=Subject:Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:To; bh=qbe7OcmNHInSfw4wKUpA570ot7f1mIV1+chcJ19JlpI=; b=WkqPlhFv5PSNxb3LpQv+hAErakQ3/DoazHP9EcsQoMKACH1irYV6rU+g/YeNfkNN2sbmhKvGAaYsaAZ9y23Zx1i3rLI8OdmdZ9/yVY0Cvq1FFTR5LzO37+4Z67hwfuSlzcSzhYiCXbpzpgJvtgV45mhYxJ8EkCQQXn/1NAPpaXY=; User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.0 In-Reply-To: <20160401094919.GT9862@port70.net> X-SA-Exim-Connect-IP: 217.235.254.81 X-SA-Exim-Mail-From: s.gottschall@dd-wrt.com X-Spam-Checker-Version: SpamAssassin 3.1.9 (2007-02-13) on webmail.newmedia-net.de X-Spam-Level: X-Spam-Status: No, score=-2.5 required=4.0 tests=ALL_TRUSTED,BAYES_00, DNS_FROM_AHBL_RHSBL,RATWARE_GECKO_BUILD autolearn=no version=3.1.9, No X-SA-Exim-Version: 4.2.1 (built Thu, 26 May 2011 15:22:33 +0200) X-SA-Exim-Scanned: Yes (on webmail.newmedia-net.de) X-NMN-MailScanner-Information: Please contact the ISP for more information X-NMN-MailScanner-ID: 1alwJm-00071m-45 X-NMN-MailScanner: Found to be clean X-NMN-MailScanner-From: s.gottschall@dd-wrt.com X-Received: from [217.235.254.81] (helo=[172.29.0.169]) by webmail.newmedia-net.de with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.72) (envelope-from ) id 1alwJm-00071m-45 for musl@lists.openwall.com; Fri, 01 Apr 2016 12:28:42 +0200 Xref: news.gmane.org gmane.linux.lib.musl.general:9811 Archived-At: Am 01.04.2016 um 11:49 schrieb Szabolcs Nagy: > * Sebastian Gottschall [2016-04-01 11:16:20 +0200]: >> I discovered that the whole recvmsg/sendmsg code is broken in mips64 >> but i found also the solution >> i throwed out all the _pad1, _pad2 crap in socket.h and the corrosponding >> code in recvmsg.c etc. >> and used size_t instead. this works at the end. i see no reason for this >> padding, since using the correct datatype will handle it in the same way. >> this solution may also work for other 64 bit targets. so proposal is fixing >> the datatype instead of using int with padding in case of 64 bit >> > the padding is needed, i think __BIG_ENDIAN > or __LITTLE_ENDIAN might not be defined properly. i checked this already. it was defined properly. the only solution was using the correct datatypes as defined in the kernel and i also checked uclibc. it uses also just size_t and nothing else. the padding results in the same datatype size, just clears the upper and lower word. but this doesnt seem to be neccessary > your fix is non-conforming and breaks both abi and api, > the definition must match socklen_t would result in the same 64bit datatype instead of int + pad (which is 64 bit too). so its conforming. i mached by header variant by reading the kernel headers which uses size_t instead of socketlen_t so i assume socketlen_t maches size_t > > http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/sys_socket.h.html > >> this here is my working struct in mips64 (big endian) >> >> struct msghdr { >> void *msg_name; >> socklen_t msg_namelen; >> struct iovec *msg_iov; >> size_t msg_iovlen; >> void *msg_control; >> size_t msg_controllen; >> int msg_flags; >> }; >> >> struct cmsghdr { >> size_t cmsg_len; >> int cmsg_level; >> int cmsg_type; >> }; >> >> >> Sebastian