Support for .S files

Support for .S files

[Sidney Manning]

[-- Attachment #1: Type: text/plain, Size: 580 bytes --]

Clang and gcc do not invoke the preprocessor on files with a lowercase .s
suffix.

 

The following addition would permit uppercase .S files.

 

diff --git a/Makefile b/Makefile

index 5a6a43b..66e9f50 100644

--- a/Makefile

+++ b/Makefile

@@ -133,6 +133,9 @@ endif

%.o: $(ARCH)/%.s

        $(AS_CMD) $(CFLAGS_ALL_STATIC)

+%.o: $(ARCH)/%.S

+       $(CC) $(CFLAGS_ALL_STATIC) -c -o $@ $<

+

%.o: %.c $(GENH) $(IMPH)

        $(CC) $(CFLAGS_ALL_STATIC) -c -o $@ $<

 

 

Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by
The Linux Foundation

 


[-- Attachment #2: Type: text/html, Size: 3101 bytes --]

Re: Support for .S files

[Rich Felker]

On Fri, Sep 25, 2015 at 01:52:26PM -0500, Sidney Manning wrote:
> Clang and gcc do not invoke the preprocessor on files with a lowercase .s
> suffix.
> 
> The following addition would permit uppercase .S files.

The intention was to avoid using the preprocessor in asm and having it
become #ifdef hell. This could be revisited (especially now as part of
the arch deduplication/refactoring) but there should first be some
discussion of the motivation (what you want to achieve with it).

Rich

RE: Support for .S files

[Sidney Manning]

> On Fri, Sep 25, 2015 at 01:52:26PM -0500, Sidney Manning wrote:
> > Clang and gcc do not invoke the preprocessor on files with a lowercase
> > .s suffix.
> >
> > The following addition would permit uppercase .S files.
> 
> The intention was to avoid using the preprocessor in asm and having it
> become #ifdef hell. This could be revisited (especially now as part of the
arch
> deduplication/refactoring) but there should first be some discussion of
the
> motivation (what you want to achieve with it).

I was experimenting with some optimized assembly and it substituted #defines
in place of register names.  Think, "#define length r2" and such making the
resulting assembly more readable.  I had made some missteps with the
Makefile because the files didn't get picked up; only later did I see that
the pattern wasn't in the Makefile.


Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by
The Linux Foundation