* Re: [PATCH 1/1] ungetc: Cast to unsigned char before push
@ 2019-10-20 4:37 wangjianjian (C)
0 siblings, 0 replies; only message in thread
From: wangjianjian (C) @ 2019-10-20 4:37 UTC (permalink / raw)
To: musl
Thanks for review. I will send a v2.
>> I believe this is actually a functional change, and a needed one for
>> conformance (to ISO C, not specific to POSIX). The issue it seems to
Yes, I check ISO C standard. It also requires returning the character
pushed back after conversion.
>> solve, which is what the change needs to be documented as, is the
>> return value when a negative value not equal to EOF is passed to
I don't quite understand. Do you mean we need document this change?
If so, where should I put it? Please tell me.
BR,
Wang Jianjian
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2019-10-20 4:37 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-20 4:37 [PATCH 1/1] ungetc: Cast to unsigned char before push wangjianjian (C)
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).