From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/14836 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "wangjianjian (C)" Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH 1/1] ungetc: Cast to unsigned char before push Date: Sun, 20 Oct 2019 04:37:59 +0000 Message-ID: <0ed5cfc952cd417097c17af55a839549@huawei.com> Reply-To: musl@lists.openwall.com Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="251371"; mail-complaints-to="usenet@blaine.gmane.org" To: "musl@lists.openwall.com" Original-X-From: musl-return-14852-gllmg-musl=m.gmane.org@lists.openwall.com Sun Oct 20 06:38:15 2019 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.89) (envelope-from ) id 1iM2yt-0013J7-0N for gllmg-musl@m.gmane.org; Sun, 20 Oct 2019 06:38:15 +0200 Original-Received: (qmail 14041 invoked by uid 550); 20 Oct 2019 04:38:13 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 14003 invoked from network); 20 Oct 2019 04:38:11 -0000 Thread-Topic: Re: [PATCH 1/1] ungetc: Cast to unsigned char before push Thread-Index: AdWHABC5eH3Rjv2HSeC6KVDNVmjLYQ== Accept-Language: en-US Content-Language: zh-CN x-originating-ip: [10.111.171.229] X-CFilter-Loop: Reflected Xref: news.gmane.org gmane.linux.lib.musl.general:14836 Archived-At: Thanks for review. I will send a v2. >> I believe this is actually a functional change, and a needed one for >> conformance (to ISO C, not specific to POSIX). The issue it seems to Yes, I check ISO C standard. It also requires returning the character=20 pushed back after conversion. >> solve, which is what the change needs to be documented as, is the >> return value when a negative value not equal to EOF is passed to I don't quite understand. Do you mean we need document this change? If so, where should I put it? Please tell me. BR, Wang Jianjian