From: Jens Gustedt <Jens.Gustedt@inria.fr>
To: musl@lists.openwall.com
Subject: [PATCH 2/3] Have different definitions of __pthread_tsd_main agree in size
Date: Sun, 10 Feb 2013 23:32:47 +0100 [thread overview]
Message-ID: <1360535367.23424.466.camel@eris.loria.fr> (raw)
When switching optimization to higher levels (-O3) and enable link time
optimization (-flto) gcc finds two instances of the __pthread_tsd_main
variable that are declared with different sizes.
The real size that is needed is known in both source files. Just use
equivalent definitions.
1 1 src/thread/pthread_self.c
diff --git a/src/thread/pthread_self.c b/src/thread/pthread_self.c
index 23dbaa5..32a6e5d 100644
--- a/src/thread/pthread_self.c
+++ b/src/thread/pthread_self.c
@@ -3,7 +3,7 @@
static struct pthread *main_thread = &(struct pthread){0};
/* pthread_key_create.c overrides this */
-static const void *dummy[1] = { 0 };
+static const void *dummy[PTHREAD_KEYS_MAX] = { 0 };
weak_alias(dummy, __pthread_tsd_main);
static int init_main_thread()
--
1.7.9.5
next reply other threads:[~2013-02-10 22:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-10 22:32 Jens Gustedt [this message]
2013-02-11 0:31 ` Rich Felker
2013-02-11 7:40 ` Jens Gustedt
2013-02-11 11:22 ` Szabolcs Nagy
2013-02-11 12:08 ` Szabolcs Nagy
2013-02-11 12:51 ` Jens Gustedt
2013-02-11 13:09 ` Szabolcs Nagy
2013-02-11 13:38 ` Jens Gustedt
2013-02-11 13:44 ` Rich Felker
2013-02-11 14:07 ` Jens Gustedt
2013-02-11 14:39 ` Szabolcs Nagy
2013-02-11 16:30 ` Jens Gustedt
2013-02-11 17:08 ` Szabolcs Nagy
2013-02-11 17:21 ` Jens Gustedt
2013-02-11 21:49 ` Rich Felker
2013-02-11 21:47 ` Rich Felker
2013-02-11 21:50 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1360535367.23424.466.camel@eris.loria.fr \
--to=jens.gustedt@inria.fr \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).