mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Jens Gustedt <jens.gustedt@inria.fr>
To: musl@lists.openwall.com
Subject: Re: [PATCH 1/3] protect some clobbered variables with volatile
Date: Mon, 18 Feb 2013 01:13:51 +0100	[thread overview]
Message-ID: <1361146431.29560.340.camel@eris.loria.fr> (raw)
In-Reply-To: <20130217175512.GE20323@brightrain.aerifal.cx>

[-- Attachment #1: Type: text/plain, Size: 1165 bytes --]

Hello Rich,
AFAIR these both occurred when compiling with -flto. I would not trust
the static analysis of the compiler at 100 % either, but this is just
an argument to have the volatile in.

The compiler is telling us that here he thinks that an optimization
might hide a intermittent write, but that by the aliasing rules it
would be OK to save a read. So better be careful and trust the
compiler that he is willing to do bad things :)

Maybe LTO is broken, yet, in that it might do some optimizations that
it shouldn't. Or maybe this exposes possible problems that were
previously hidden because the write was in a different compilation
unit than the read. Who knows.

In any case, the performance hit should be limited, and my personal
preference would tend towards safety and calming down the compiler.

Jens

-- 
:: INRIA Nancy Grand Est :: http://www.loria.fr/~gustedt/   ::
:: AlGorille ::::::::::::::: office Nancy : +33 383593090   ::
:: ICube :::::::::::::: office Strasbourg : +33 368854536   ::
:: ::::::::::::::::::::::::::: gsm France : +33 651400183   ::
:: :::::::::::::::::::: gsm international : +49 15737185122 ::




[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

      reply	other threads:[~2013-02-18  0:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-10 22:31 Jens Gustedt
2013-02-11  1:14 ` Rich Felker
2013-02-17 17:55 ` Rich Felker
2013-02-18  0:13   ` Jens Gustedt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1361146431.29560.340.camel@eris.loria.fr \
    --to=jens.gustedt@inria.fr \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).