From: Jens Gustedt <Jens.Gustedt@inria.fr>
To: musl@lists.openwall.com
Subject: [PATCH] bugfix: initialize a state variable in lio_wait
Date: Sun, 16 Jun 2013 00:01:20 +0200 [thread overview]
Message-ID: <1371333657.16425.350.camel@eris.loria.fr> (raw)
got_err was only set to 1 in case of error, but never written
otherwise. This resulted in situations where lio_listio returned -1 for a
request with cnt == 1, but where that sole request had completed.
---
src/aio/lio_listio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/aio/lio_listio.c b/src/aio/lio_listio.c
index 64a6ebc..07145dd 100644
--- a/src/aio/lio_listio.c
+++ b/src/aio/lio_listio.c
@@ -13,7 +13,7 @@ struct lio_state {
static int lio_wait(struct lio_state *st)
{
- int i, err, got_err;
+ int i, err, got_err = 0;
int cnt = st->cnt;
struct aiocb **cbs = st->cbs;
--
1.7.9.5
next reply other threads:[~2013-06-15 22:01 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-15 22:01 Jens Gustedt [this message]
2013-06-15 22:16 ` Szabolcs Nagy
2013-06-16 5:40 ` Rich Felker
2013-06-16 7:22 ` Jens Gustedt
2013-06-16 9:31 ` Jens Gustedt
2013-06-16 10:18 ` Justin Cormack
2013-06-16 10:43 ` valgrind problems Jens Gustedt
2013-06-16 11:39 ` Szabolcs Nagy
2013-06-16 14:16 ` Jens Gustedt
2013-06-16 14:36 ` Rich Felker
2013-06-16 14:31 ` Rich Felker
2013-06-16 15:26 ` Jens Gustedt
2013-06-16 15:31 ` Rich Felker
2013-06-16 15:58 ` Jens Gustedt
2013-06-16 16:04 ` Rich Felker
2013-06-16 17:39 ` Jens Gustedt
2013-06-16 19:16 ` Rich Felker
2013-06-16 19:38 ` Szabolcs Nagy
2013-06-16 19:41 ` Rich Felker
2013-06-16 17:40 ` Szabolcs Nagy
2013-06-16 18:02 ` Jens Gustedt
2013-06-16 19:25 ` Szabolcs Nagy
2013-06-16 19:29 ` Rich Felker
2013-06-16 14:24 ` [PATCH] bugfix: initialize a state variable in lio_wait Rich Felker
2013-06-16 15:48 ` Jens Gustedt
2013-06-16 15:37 ` Szabolcs Nagy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1371333657.16425.350.camel@eris.loria.fr \
--to=jens.gustedt@inria.fr \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).