mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Michael Forney <mforney@mforney.org>
To: musl@lists.openwall.com
Subject: [PATCH] getcwd: Set errno to EINVAL when size == 0
Date: Sun,  6 Oct 2013 23:08:24 -0700	[thread overview]
Message-ID: <1381126104-24579-1-git-send-email-mforney@mforney.org> (raw)

According to POSIX,

    The getcwd() function shall fail if:

    [EINVAL]
    The size argument is 0.
    [ERANGE]
    The size argument is greater than 0, but is smaller than the length
    of the string +1.
---
 src/unistd/getcwd.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/unistd/getcwd.c b/src/unistd/getcwd.c
index 2e540cd..0238fa7 100644
--- a/src/unistd/getcwd.c
+++ b/src/unistd/getcwd.c
@@ -8,6 +8,10 @@ char *getcwd(char *buf, size_t size)
 {
 	char tmp[PATH_MAX];
 	if (!buf) buf = tmp, size = PATH_MAX;
+	else if (size == 0) {
+		errno = EINVAL;
+		return 0;
+	}
 	if (syscall(SYS_getcwd, buf, size) < 0) return 0;
 	return buf == tmp ? strdup(buf) : buf;
 }
-- 
1.8.4



             reply	other threads:[~2013-10-07  6:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-07  6:08 Michael Forney [this message]
2013-10-07  6:38 ` Jens Gustedt
2013-10-07 16:21   ` Rich Felker
2013-10-07 17:15     ` Justin Cormack
2013-10-07 17:25       ` Rich Felker
2013-10-07 23:29     ` Michael Forney
2013-10-08 23:48       ` Rich Felker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1381126104-24579-1-git-send-email-mforney@mforney.org \
    --to=mforney@mforney.org \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).