Re: build with clang-3.4 warnings report

[Jens Gustedt <jens.gustedt@inria.fr>]

[-- Attachment #1.1: Type: text/plain, Size: 1387 bytes --]

Am Samstag, den 05.04.2014, 12:35 -0400 schrieb Rich Felker:
> I'd be interested in seeing what you mean by some of these, but note
> that these are all +'s and don't seem to have any concrete advantages
> over the current code.

I attach the cleanest and simplest version. (forget about the handling
of the historic mips case, if you don't like it)

> I was talking about the approach with designated initializers, which I
> assumed would look something like:
> 
> {
> 	[EBADF] = "Bad file descriptor",
> 	[EILSEQ] = "Illegal sequence",
> 	...
> }

sorry I wasn't clear enough, yes the one you had in mind would need an
array of pointers, instead of "unsigned char".

I was thinking of using designated initializers to compute offsets. In
the example that is joint, the main change in size is due to the
change from "unsigned char" to "unsigned short" for the table and
because there are some holes. (+200)

When placing the default entry in front instead of last, this shaves
of about 50, again. (so +150 in total)

Jens


-- 
:: INRIA Nancy Grand Est :: http://www.loria.fr/~gustedt/   ::
:: AlGorille ::::::::::::::: office Nancy : +33 383593090   ::
:: ICube :::::::::::::: office Strasbourg : +33 368854536   ::
:: ::::::::::::::::::::::::::: gsm France : +33 651400183   ::
:: :::::::::::::::::::: gsm international : +49 15737185122 ::




[-- Attachment #1.2: strerror.c --]
[-- Type: text/x-csrc, Size: 1242 bytes --]

#include <errno.h>
#include <string.h>
#include <stddef.h>

/* mips has one error code outside of the 8-bit range due to a
 * historical typo, so we just remap it. */
#define MIPSACCIDENT 1133

#if EDQUOT==MIPSACCIDENT
# define MIPSSPECIAL (MIPSACCIDENT&0xFF)
# undef EDQUOT
# define EDQUOT MIPSSPECIAL
#else
# define MIPSSPECIAL 0
#endif


#define E(a,b) char _err ## a[sizeof b];
struct errstruct {
#include "__strerror.h"
};

#undef E
#define E(a,b) ._err ## a = { b },
static const struct errstruct errmsg = {
#include "__strerror.h"
};

#undef E
#define E(a,b) [a] = offsetof(struct errstruct, _err ## a),
static const unsigned short erroffset[] = {
#include "__strerror.h"
};

enum { errmax = (sizeof erroffset)/(sizeof erroffset[0]), };

char *strerror(int e)
{
        if (MIPSSPECIAL) {
          switch (e) {
            /* would be simpler if _err0 would be first field */
          case MIPSSPECIAL: return (char*)errmsg._err0;
          case MIPSACCIDENT: e=MIPSSPECIAL; break;
          }
        }
        /* would be simpler if _err0 would be first field */
        if (((unsigned)e >= (unsigned)errmax) || !erroffset[e]) e = 0;
        return erroffset[e] + (char*)&errmsg;
}

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]