From: Jens Gustedt <jens.gustedt@inria.fr>
To: Rich Felker <dalias@libc.org>
Cc: musl@lists.openwall.com
Subject: Re: Multi-threaded performance progress
Date: Wed, 27 Aug 2014 11:53:10 +0200 [thread overview]
Message-ID: <1409133190.4476.28.camel@eris.loria.fr> (raw)
In-Reply-To: <20140826213625.GJ12888@brightrain.aerifal.cx>
[-- Attachment #1: Type: text/plain, Size: 1877 bytes --]
Am Dienstag, den 26.08.2014, 17:36 -0400 schrieb Rich Felker:
> Fixing it should be trivial via the design I mentioned earlier: don't
> use a waiter flag like this, but instead offset the initial value of
> ref by +1 and a_dec it just before waiting. As in other places, of
> course, a wake to an invalid address is possible either way; this is
> "fixable" if necessary via FUTEX_WAKE_OP (having the kernel do the
> atomic dec after acquiring the futex bin locks).
generally it would be nice to have such a lock functionality that
takes care of the waiters inside the int itself, this could perhaps be
used in other places
> > Ok, I'll try to switch to one-step-at-a-time-mode.
>
> OK.
ok, so in a follow up I will send two patches that are the essence of
that. It doesn't do the booking from above, let's keep that for later.
Jens Gustedt (2):
Let the signaler do all work concerning consistency of the list
avoid taking _c_lock if we know it isn't necessary
src/thread/pthread_cond_timedwait.c | 62 +++++++++++++++++++++++++++--------
1 file changed, 48 insertions(+), 14 deletions(-)
> > > Or, if you don't have time to spend on side projects like test
> > > cases, maybe someone else could test it?
> >
> > Not at the moment. I would prefer to have a C thread implementation by
> > the end of the week that we could agree upon.
>
> Yes, that would be very nice!
ok, so I will be turning back to that, and as said that will be a
version of C threads that use the POSIX lock structures transparently.
Jens
--
:: INRIA Nancy Grand Est ::: AlGorille ::: ICube/ICPS :::
:: ::::::::::::::: office Strasbourg : +33 368854536 ::
:: :::::::::::::::::::::: gsm France : +33 651400183 ::
:: ::::::::::::::: gsm international : +49 15737185122 ::
:: http://icube-icps.unistra.fr/index.php/Jens_Gustedt ::
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2014-08-27 9:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-26 3:43 Rich Felker
2014-08-26 7:04 ` Jens Gustedt
2014-08-26 10:44 ` Szabolcs Nagy
2014-08-26 11:09 ` Jens Gustedt
2014-08-26 16:35 ` Jens Gustedt
2014-08-26 17:32 ` Rich Felker
2014-08-26 17:53 ` Rich Felker
2014-08-26 18:30 ` Jens Gustedt
2014-08-26 19:05 ` Rich Felker
2014-08-26 19:34 ` Jens Gustedt
2014-08-26 20:26 ` Rich Felker
2014-08-26 21:15 ` Jens Gustedt
2014-08-26 21:36 ` Rich Felker
2014-08-27 9:53 ` Jens Gustedt [this message]
2014-08-27 16:47 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1409133190.4476.28.camel@eris.loria.fr \
--to=jens.gustedt@inria.fr \
--cc=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).