Re: [PATCH] Convert some is* macros to inline functions

[Jens Gustedt <jens.gustedt@inria.fr>]

[-- Attachment #1: Type: text/plain, Size: 1176 bytes --]

Am Montag, den 13.10.2014, 17:20 +0300 schrieb Sergey Dmitrouk:
> Hello,
> 
> eight is* functions of C standard library are also declared in form of
> macros in headers provided by musl.  Standard doesn't seem to allow them
> to be implemented as macros.

why would that be?

In section 7.1.4 the C standard explicitly says:

  > Any function declared in a header may be additionally implemented
  > as a function-like macro defined in the header, ...


> Please find the attached patch that proposes replacing these macros
> with inline functions.

I don't think that this is necessary.

They only advantage of inline functions, here would be that the
conversion of the arguments would be done with implicit conversions
instead of casts. (For the macros this could be achieved by using
compound literals instead of casts, but well...)

Jens


-- 
:: INRIA Nancy Grand Est ::: AlGorille ::: ICube/ICPS :::
:: ::::::::::::::: office Strasbourg : +33 368854536   ::
:: :::::::::::::::::::::: gsm France : +33 651400183   ::
:: ::::::::::::::: gsm international : +49 15737185122 ::
:: http://icube-icps.unistra.fr/index.php/Jens_Gustedt ::



[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]