From: "Jörg Krause" <jkrause@posteo.de>
To: musl@lists.openwall.com
Subject: Re: pthread_equal
Date: Mon, 08 Dec 2014 17:18:41 +0100 [thread overview]
Message-ID: <1418055521.15892.16.camel@posteo.de> (raw)
In-Reply-To: <20141208145604.GC4574@brightrain.aerifal.cx>
On Mo, 2014-12-08 at 09:56 -0500, Rich Felker wrote:
> On Mon, Dec 08, 2014 at 03:42:25PM +0100, Jörg Krause wrote:
> > Why does musl declares pthread_equal both as macro and as function?
>
> C and POSIX allow any of their standard functions to be provided as
> macros too, but the function definition must always be provided. The
> reason I put the macro in musl is simply that it's easy to do and
> gives better code (trivial inline comparison rather than spilling all
> registers and making a function call) and it's not something where the
> implementation could change or need to change.
>
> Rich
I see! The problem was, that MPD (Music Player Daemon, implemented in C
++) for instance used ::pthread_equal(id, other_id) which did not build
with musl because of the macro expansion.
The maintainer removed the namespace operator to get it work with musl:
http://git.musicpd.org/cgit/master/mpd.git/commit/?h=v0.18.x&id=d8fc2db910a11dbbba53ba7ecf96d0e32a081076
Jörg
next prev parent reply other threads:[~2014-12-08 16:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-08 14:42 pthread_equal Jörg Krause
2014-12-08 14:56 ` pthread_equal Rich Felker
2014-12-08 16:18 ` Jörg Krause [this message]
2014-12-08 16:25 ` pthread_equal Rich Felker
2014-12-08 21:11 ` pthread_equal Jörg Krause
2014-12-09 0:06 ` pthread_equal Rich Felker
2014-12-09 2:18 ` [PATCH] don't shadow functions with macros in C++ Bobby Bingham
2014-12-09 22:33 ` Jörg Krause
2014-12-10 3:37 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418055521.15892.16.camel@posteo.de \
--to=jkrause@posteo.de \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).