From: Denys Vlasenko <vda.linux@googlemail.com>
To: musl@lists.openwall.com, Rich Felker <dalias@libc.org>
Cc: Denys Vlasenko <vda.linux@googlemail.com>
Subject: [PATCH 2/2] x86_64/memset: align destination to 8 byte boundary
Date: Thu, 12 Feb 2015 18:17:03 +0100 [thread overview]
Message-ID: <1423761423-30050-2-git-send-email-vda.linux@googlemail.com> (raw)
In-Reply-To: <1423761423-30050-1-git-send-email-vda.linux@googlemail.com>
8-byte alignment gives ~25% speedup on "rep stosq" memsets
to L1 cache, compared to intentionally misaligned ones.
It is a smaller win of ~15% on larger memsets to L2 too.
Measured on Intel Sandy Bridge CPU (i7-2620M, 2.70GHz)
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
---
src/string/x86_64/memset.s | 22 +++++++++++++++++++++-
1 file changed, 21 insertions(+), 1 deletion(-)
diff --git a/src/string/x86_64/memset.s b/src/string/x86_64/memset.s
index 523caa0..5c9e333 100644
--- a/src/string/x86_64/memset.s
+++ b/src/string/x86_64/memset.s
@@ -4,16 +4,23 @@ memset:
movzbq %sil,%rax
cmp $16,%rdx
jb .Less_than_16
+
test %esi,%esi
jnz .L_widen_rax # unlikely
.L_widened:
- lea -1(%rdx),%rcx
mov %rdi,%r8
+
+ test $7,%dil
+ jnz .L_align # unlikely
+.L_aligned:
+
+ lea -1(%rdx),%rcx
shr $3,%rcx
mov %rax,-8(%rdi,%rdx)
rep
stosq
+
mov %r8,%rax
ret
@@ -23,6 +30,19 @@ memset:
imul %rsi,%rax
jmp .L_widened
+# 8-byte alignment gives ~25% speedup on "rep stosq" memsets
+# to L1 cache, compared to intentionally misaligned ones.
+# It is a smaller win of ~15% on larger memsets to L2 too.
+# Measured on Intel Sandy Bridge CPU (i7-2620M, 2.70GHz)
+.L_align:
+ mov %rax,(%rdi)
+1: inc %rdi
+ dec %rdx
+ test $7,%dil
+ jnz 1b
+ jmp .L_aligned
+
+
.Less_than_16:
test %edx,%edx
jz .L_ret
--
1.8.1.4
next prev parent reply other threads:[~2015-02-12 17:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-12 17:17 [PATCH 1/2] x86_64/memset: avoid multiply insn if possible Denys Vlasenko
2015-02-12 17:17 ` Denys Vlasenko [this message]
2015-02-12 17:27 ` Rich Felker
2015-02-12 19:26 ` Denys Vlasenko
2015-02-12 20:36 ` Denys Vlasenko
2015-02-13 7:24 ` Rich Felker
2015-02-13 16:38 ` Denys Vlasenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1423761423-30050-2-git-send-email-vda.linux@googlemail.com \
--to=vda.linux@googlemail.com \
--cc=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).