mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Alexander Monakov <amonakov@ispras.ru>
To: musl@lists.openwall.com
Cc: Alexander Monakov <amonakov@ispras.ru>
Subject: [PATCH] replace 'hlt' by 'ud2' in i386/x32/x86_64 a_crash implementations
Date: Thu, 16 Apr 2015 20:58:59 +0300	[thread overview]
Message-ID: <1429207139-10359-1-git-send-email-amonakov@ispras.ru> (raw)

---
ud2 is also what GCC and Clang use to implement __builtin_trap()

ud2 causes SIGILL rather than SIGSEGV; SIGSEGV is more likely to have a custom
signal handler installed

 arch/i386/atomic.h   | 2 +-
 arch/x32/atomic.h    | 2 +-
 arch/x86_64/atomic.h | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/i386/atomic.h b/arch/i386/atomic.h
index 4fe7bde..2f78d31 100644
--- a/arch/i386/atomic.h
+++ b/arch/i386/atomic.h
@@ -103,7 +103,7 @@ static inline void a_barrier()
 
 static inline void a_crash()
 {
-	__asm__ __volatile__( "hlt" : : : "memory" );
+	__asm__ __volatile__( "ud2" : : : "memory" );
 }
 
 
diff --git a/arch/x32/atomic.h b/arch/x32/atomic.h
index 333098c..a8e7603 100644
--- a/arch/x32/atomic.h
+++ b/arch/x32/atomic.h
@@ -98,7 +98,7 @@ static inline void a_barrier()
 
 static inline void a_crash()
 {
-	__asm__ __volatile__( "hlt" : : : "memory" );
+	__asm__ __volatile__( "ud2" : : : "memory" );
 }
 
 
diff --git a/arch/x86_64/atomic.h b/arch/x86_64/atomic.h
index 333098c..a8e7603 100644
--- a/arch/x86_64/atomic.h
+++ b/arch/x86_64/atomic.h
@@ -98,7 +98,7 @@ static inline void a_barrier()
 
 static inline void a_crash()
 {
-	__asm__ __volatile__( "hlt" : : : "memory" );
+	__asm__ __volatile__( "ud2" : : : "memory" );
 }
 
 
-- 
2.1.3



             reply	other threads:[~2015-04-16 17:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-16 17:58 Alexander Monakov [this message]
2015-04-17  5:55 ` Rich Felker
2015-04-17  8:12   ` Alexander Monakov
2015-04-17 16:44     ` Rich Felker
2015-04-17 18:48       ` Alexander Monakov
2015-04-17 20:23         ` Rich Felker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1429207139-10359-1-git-send-email-amonakov@ispras.ru \
    --to=amonakov@ispras.ru \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).