From: Shiz <hi@shiz.me>
To: musl@lists.openwall.com
Cc: Shiz <hi@shiz.me>
Subject: [PATCH] add unused flag check arguments to toolchain flag detection
Date: Thu, 28 May 2015 04:50:10 +0200 [thread overview]
Message-ID: <1432781410-7914-1-git-send-email-hi@shiz.me> (raw)
[-- Attachment #1: Type: text/plain, Size: 446 bytes --]
this checks whether -Werror=unknown-warning-option and
-Werror=unused-command-line-argument are supported by the toolchain. if so,
it adds those flags to the tryflag and tryldflag checks in ./configure.
so far only clang supports these flags, but clang is also the only toolchain
I've encountered that ignores unrecognized arguments instead of erroring out.
---
configure | 14 ++++++++++++--
1 file changed, 12 insertions(+), 2 deletions(-)
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-add-unused-flag-check-arguments-to-toolchain-flag-de.patch --]
[-- Type: text/x-patch; name="0001-add-unused-flag-check-arguments-to-toolchain-flag-de.patch", Size: 1432 bytes --]
diff --git a/configure b/configure
index 143dc92..08acef0 100755
--- a/configure
+++ b/configure
@@ -80,7 +80,7 @@ fi
tryflag () {
printf "checking whether compiler accepts %s... " "$2"
echo "typedef int x;" > "$tmpc"
-if $CC $2 -c -o /dev/null "$tmpc" >/dev/null 2>&1 ; then
+if $CC $CFLAGS_TRY $2 -c -o /dev/null "$tmpc" >/dev/null 2>&1 ; then
printf "yes\n"
eval "$1=\"\${$1} \$2\""
eval "$1=\${$1# }"
@@ -94,7 +94,7 @@ fi
tryldflag () {
printf "checking whether linker accepts %s... " "$2"
echo "typedef int x;" > "$tmpc"
-if $CC -nostdlib -shared "$2" -o /dev/null "$tmpc" >/dev/null 2>&1 ; then
+if $CC $LDFLAGS_TRY -nostdlib -shared "$2" -o /dev/null "$tmpc" >/dev/null 2>&1 ; then
printf "yes\n"
eval "$1=\"\${$1} \$2\""
eval "$1=\${$1# }"
@@ -113,7 +113,9 @@ CFLAGS_C99FSE=
CFLAGS_AUTO=
CFLAGS_MEMOPS=
CFLAGS_NOSSP=
+CFLAGS_TRY=
LDFLAGS_AUTO=
+LDFLAGS_TRY=
OPTIMIZE_GLOBS=
prefix=/usr/local/musl
exec_prefix='$(prefix)'
@@ -205,6 +207,14 @@ exit 1
fi
#
+# Figure out options to force errors on unknown flags.
+#
+tryflag CFLAGS_TRY -Werror=unknown-warning-option
+tryflag CFLAGS_TRY -Werror=unused-command-line-argument
+tryldflag LDFLAGS_TRY -Wl,-Werror=unknown-warning-option
+tryldflag LDFLAGS_TRY -Wl,-Werror=unused-command-line-argument
+
+#
# Need to know if the compiler is gcc to decide whether to build the
# musl-gcc wrapper, and for critical bug detection in some gcc versions.
#
next reply other threads:[~2015-05-28 2:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-28 2:50 Shiz [this message]
2015-05-28 3:32 ` Rich Felker
2015-05-28 3:51 ` Mark Cilissen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1432781410-7914-1-git-send-email-hi@shiz.me \
--to=hi@shiz.me \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).