From: Alexander Monakov <amonakov@ispras.ru>
To: musl@lists.openwall.com
Subject: [PATCH v2 6/6] dynlink.c: store bloom filter size in struct dso
Date: Sun, 28 Jun 2015 02:48:35 +0300 [thread overview]
Message-ID: <1435448915-28419-7-git-send-email-amonakov@ispras.ru> (raw)
In-Reply-To: <1435448915-28419-1-git-send-email-amonakov@ispras.ru>
This slightly speeds up gnu_lookup_filtered by avoiding pointer chasing.
---
src/ldso/dynlink.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/ldso/dynlink.c b/src/ldso/dynlink.c
index f181209..12e8c25 100644
--- a/src/ldso/dynlink.c
+++ b/src/ldso/dynlink.c
@@ -59,6 +59,7 @@ struct dso {
Sym *syms;
uint32_t *hashtab;
uint32_t *ghashtab;
+ uint32_t ghashmask;
struct udiv gudiv;
int16_t *versym;
char *strings;
@@ -259,7 +260,7 @@ static Sym *gnu_lookup_filtered(uint32_t h1, uint32_t *hashtab, struct dso *dso,
uint32_t fofs, size_t fmask)
{
const size_t *bloomwords = (const void *)(hashtab+4);
- size_t f = bloomwords[fofs & (hashtab[2]-1)];
+ size_t f = bloomwords[fofs & dso->ghashmask];
if (!(f & fmask)) return 0;
f >>= (h1 >> hashtab[3]) % (8 * sizeof f);
@@ -758,6 +759,7 @@ static void decode_dyn(struct dso *p)
p->rpath_orig = (void *)(p->strings + dyn[DT_RUNPATH]);
if (search_vec(p->dynv, dyn, DT_GNU_HASH)) {
p->ghashtab = (void *)(p->base + *dyn);
+ p->ghashmask = p->ghashtab[2]-1;
precompute_udiv(p->ghashtab[0], &p->gudiv);
}
if (search_vec(p->dynv, dyn, DT_VERSYM))
next prev parent reply other threads:[~2015-06-27 23:48 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-23 23:24 [PATCH 0/5] gnu-hash speedups Alexander Monakov
2015-06-23 23:24 ` [PATCH 1/5] dynlink.c: use bloom filter in gnu hash lookup Alexander Monakov
2015-06-24 5:39 ` Rich Felker
2015-06-24 6:29 ` Alexander Monakov
2015-06-24 6:32 ` Alexander Monakov
2015-06-24 6:50 ` Rich Felker
2015-06-23 23:24 ` [PATCH 2/5] dynlink.c: compute modulus via magic multiplication Alexander Monakov
2015-06-24 4:18 ` Alexander Monakov
2015-06-24 4:19 ` Rich Felker
2015-06-24 4:24 ` Rich Felker
2015-06-24 4:32 ` Alexander Monakov
2015-06-24 5:13 ` Rich Felker
2015-06-24 6:08 ` Alexander Monakov
2015-06-24 6:39 ` Rich Felker
2015-06-23 23:24 ` [PATCH 3/5] dynlink.c: slim down gnu_lookup Alexander Monakov
2015-06-23 23:24 ` [PATCH 4/5] dynlink.c: pass gnu-hash table pointer to gnu_lookup Alexander Monakov
2015-06-23 23:24 ` [PATCH 5/5] dynlink.c: use a faster expression in gnu_hash Alexander Monakov
2015-06-27 23:48 ` [PATCH v2 0/6] gnu-hash speedups Alexander Monakov
2015-06-27 23:48 ` [PATCH v2 1/6] dynlink.c: use a faster expression in gnu_hash Alexander Monakov
2015-06-27 23:48 ` [PATCH v2 2/6] dynlink.c: use bloom filter in gnu hash lookup Alexander Monakov
2015-06-27 23:48 ` [PATCH v2 3/6] dynlink.c: slim down gnu_lookup Alexander Monakov
2015-06-27 23:48 ` [PATCH v2 4/6] dynlink.c: pass gnu-hash table pointer to gnu_lookup Alexander Monakov
2015-06-28 0:05 ` Alexander Monakov
2015-06-28 8:59 ` Alexander Monakov
2015-06-27 23:48 ` [PATCH v2 5/6] dynlink.c: compute modulus via magic multiplication Alexander Monakov
2015-06-30 17:51 ` Rich Felker
2015-06-27 23:48 ` Alexander Monakov [this message]
2015-06-28 2:45 ` [PATCH v2 0/6] gnu-hash speedups Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1435448915-28419-7-git-send-email-amonakov@ispras.ru \
--to=amonakov@ispras.ru \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).