From: Alex Dowad <alexinbeijing@gmail.com>
To: musl@lists.openwall.com
Subject: [PATCH 2/5] When generating CFI for i386 asm, don't mistake an FDIV instruction for DIV
Date: Fri, 2 Oct 2015 13:32:33 +0200 [thread overview]
Message-ID: <1443785556-27473-2-git-send-email-alexinbeijing@gmail.com> (raw)
In-Reply-To: <1443785556-27473-1-git-send-email-alexinbeijing@gmail.com>
...that would cause the script to erroneously conclude that the values of EAX
and EDX have been overwritten.
Probably won't make a difference, but it's just as well to get it right...
---
tools/add-cfi.i386.awk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/add-cfi.i386.awk b/tools/add-cfi.i386.awk
index b8bdd7f..2da1899 100644
--- a/tools/add-cfi.i386.awk
+++ b/tools/add-cfi.i386.awk
@@ -190,7 +190,7 @@ function trashed(register) {
}
/i?mul [^,]*$/ { trashed("eax"); trashed("edx") }
/i?mul %e(ax|bx|cx|dx|si|di|bp),/ { trashed(get_reg1()) }
-/i?div/ { trashed("eax"); trashed("edx") }
+/^i?div/ { trashed("eax"); trashed("edx") }
/(dec|inc|not|neg|pop) %e(ax|bx|cx|dx|si|di|bp)/ { trashed(get_reg()) }
/cpuid/ { trashed("eax"); trashed("ebx"); trashed("ecx"); trashed("edx") }
--
2.0.0.GIT
next prev parent reply other threads:[~2015-10-02 11:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-02 11:32 [PATCH 1/5] Pull a couple common AWK functions for CFI scripts into separate file Alex Dowad
2015-10-02 11:32 ` Alex Dowad [this message]
2015-10-02 11:32 ` [PATCH 3/5] When generating CFI for i386 asm, don't mistake an FMUL instruction for MUL Alex Dowad
2015-10-02 11:32 ` [PATCH 4/5] In i386 CFI script, binary ops like ADD, AND, etc. modify the 2nd operand, not 1st Alex Dowad
2015-10-02 11:32 ` [PATCH 5/5] Add script to add CFI directives to asm files in debug builds of x86_64 Alex Dowad
2015-10-08 21:37 ` [PATCH 1/5] Pull a couple common AWK functions for CFI scripts into separate file Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1443785556-27473-2-git-send-email-alexinbeijing@gmail.com \
--to=alexinbeijing@gmail.com \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).