From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/11390 Path: news.gmane.org!.POSTED!not-for-mail From: Julien Ramseier Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH] glob: fix / matching Date: Sat, 3 Jun 2017 18:15:18 +0200 Message-ID: <144F0708-D8DE-4161-82CD-114254732960@gmail.com> References: <20170528015918.GC1627@brightrain.aerifal.cx> <20170528025520.GF1627@brightrain.aerifal.cx> <20170601020042.GJ1627@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: multipart/alternative; boundary="Apple-Mail=_DBBAD4DA-80BB-4C20-B573-A4B6F1BFC6D8" X-Trace: blaine.gmane.org 1496506537 25539 195.159.176.226 (3 Jun 2017 16:15:37 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 3 Jun 2017 16:15:37 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-11403-gllmg-musl=m.gmane.org@lists.openwall.com Sat Jun 03 18:15:34 2017 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.84_2) (envelope-from ) id 1dHBi6-0006Lf-R5 for gllmg-musl@m.gmane.org; Sat, 03 Jun 2017 18:15:31 +0200 Original-Received: (qmail 21700 invoked by uid 550); 3 Jun 2017 16:15:33 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 21655 invoked from network); 3 Jun 2017 16:15:33 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:message-id:mime-version:subject:date:references:to:in-reply-to; bh=RpasvdR6BdGmXVcLKAVU96RyD6r68w5tYvdZplJDtJk=; b=N8cohYezCRNd7cakMuhhxzQPfClTYDG0z+OYL4wIlhjO1U0PSVDuOSYZSNAc/SPAMK djUp6OBl9uJntLDVyhzOZfibs3z8amrCvw8dZlg+GocoAOfFtXLZEHKUbRfdwWTq8TiV a7kALN6p4eIwb6sK/XudKWr96mS9P19fxN1uO/gxhUEG+2OCICQ67PaZYweH63YQ6qB9 etSmmroZmoijwAEfTAuCoBCh0Jhc0iVf3OpG9ogQVT5qp5fyO1oIgjb0h6xdbX/K1/RW GwGa5lDyjrfi2//C6+yGPusYUhoqfEBVg73MR7oolGaCiefcsFg0RsnjNfuDMNdlMk0t 4Rfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :references:to:in-reply-to; bh=RpasvdR6BdGmXVcLKAVU96RyD6r68w5tYvdZplJDtJk=; b=FiBsJyegKQ6pJ/0a4O6TBK2cvdJ6/CgZOwl6WpqoImefSJCVGNNaEuklq3KSsbAeCO w7OQDLlhCUGoYyGw6kx4Ftqbme5wsFr2VwC87lHc4RjVaBY3pjIbEDUUL/90TFmwBAiP LU0TCOHisHdtlhmb4e2LDX3LS+a2lqAYmWCDnscmAMZgSE4Yz8ZbXaqrw9Y15yOLUDDs jn/n7MlEtuqyeY3J7K421ogtWZixYhreJqVcJE9Tz+cEWFWuRqute/3bpsBB+Vh7UyL0 1cezW7MeX4qo3jTOfCSVUYk155gKqunLHU0M1LJVQY972wfDFTdPfljpiKgd4e1DYcKy K+Eg== X-Gm-Message-State: AODbwcCvuokscX/uRROk1k4E4E2BvW9g549tTPYlrTmXZnaD+eXsDliT LSRfns8in/EZ3M2VdCE= X-Received: by 10.80.210.195 with SMTP id q3mr9988375edg.82.1496506521460; Sat, 03 Jun 2017 09:15:21 -0700 (PDT) In-Reply-To: <20170601020042.GJ1627@brightrain.aerifal.cx> X-Mailer: Apple Mail (2.3124) Xref: news.gmane.org gmane.linux.lib.musl.general:11390 Archived-At: --Apple-Mail=_DBBAD4DA-80BB-4C20-B573-A4B6F1BFC6D8 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > Le 1 juin 2017 =C3=A0 04:00, Rich Felker a =C3=A9crit = : >=20 > Indeed. How about the attached? >=20 > I did look at your patch, and although it's probably fine, it does > have additional side effects like moving the length check across the > slash-skipping. That's part of why I looked for a minimally invasive > approach. >=20 > Rich > Yes, this should work too. --Apple-Mail=_DBBAD4DA-80BB-4C20-B573-A4B6F1BFC6D8 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8
Le 1 juin 2017 =C3=A0 04:00, Rich Felker <dalias@libc.org> a = =C3=A9crit :

Indeed. How about the = attached?

I did look at your patch, and although it's = probably fine, it does
have additional side effects like moving = the length check across the
slash-skipping. That's part of = why I looked for a minimally invasive
approach.

Rich
<globroot.diff>

Yes, this = should work too.

= --Apple-Mail=_DBBAD4DA-80BB-4C20-B573-A4B6F1BFC6D8--