mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Alexander Monakov <amonakov@ispras.ru>
To: musl@lists.openwall.com
Subject: [PATCH 0/3] env functions overhaul
Date: Sun, 13 Mar 2016 21:53:47 +0300	[thread overview]
Message-ID: <1457895230-13602-1-git-send-email-amonakov@ispras.ru> (raw)

Hello,

recently, fixing benign UB in unsetenv unearthed bigger issues in putenv, and
prompted an overhaul. I still have to improve env testing on libc-test side,
but I think I'm done with code tuning on the musl side, and pretty happy with
the result. Patches 2 and 3 are followups to stuff discussed on IRC; I feel
they are not essential. Patch 1 is the overhaul itself. I hope that new code
is easy to follow. It should also improve code size nicely; on x86-64 I got
(.text size change after patch 1/3 only; .bss grows by one pointer):

   text   text   filename
     17     17   obj/src/env/clearenv.o
    140     97   obj/src/env/getenv.o
    491    334   obj/src/env/putenv.o
    215    284   obj/src/env/setenv.o
    283    140   obj/src/env/unsetenv.o

Thanks.
Alexander


             reply	other threads:[~2016-03-13 18:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-13 18:53 Alexander Monakov [this message]
2016-03-13 18:53 ` [PATCH 1/3] overhaul environment functions Alexander Monakov
2016-03-19 16:46   ` Rich Felker
2016-03-19 18:11     ` Alexander Monakov
2016-03-20  0:23       ` Rich Felker
2016-03-20  4:15         ` Alexander Monakov
2016-03-20 19:56           ` Rich Felker
2016-03-20 20:15             ` Alexander Monakov
2016-03-21 12:45               ` Alexander Monakov
2016-03-13 18:53 ` [PATCH 2/3] env: remove duplicates when adding to environment Alexander Monakov
2016-03-13 18:53 ` [PATCH 3/3] env: free allocations in clearenv Alexander Monakov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1457895230-13602-1-git-send-email-amonakov@ispras.ru \
    --to=amonakov@ispras.ru \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).