From: "Timo Teräs" <timo.teras@iki.fi>
To: musl@lists.openwall.com
Cc: "Timo Teräs" <timo.teras@iki.fi>
Subject: [PATCH] crypt_blowfish: allow short salt strings
Date: Fri, 25 Mar 2016 14:12:35 +0200 [thread overview]
Message-ID: <1458907955-8698-1-git-send-email-timo.teras@iki.fi> (raw)
assume the remainder of the salt to be zero bits.
---
src/crypt/crypt_blowfish.c | 2 ++
1 file changed, 2 insertions(+)
Any comments if this makes sense?
There seems to be some test suites that even verify that short
salt strings should succeed.
See: http://bugs.alpinelinux.org/issues/5141
diff --git a/src/crypt/crypt_blowfish.c b/src/crypt/crypt_blowfish.c
index d3f7985..d1f5588 100644
--- a/src/crypt/crypt_blowfish.c
+++ b/src/crypt/crypt_blowfish.c
@@ -365,6 +365,7 @@ static const unsigned char BF_atoi64[0x60] = {
#define BF_safe_atoi64(dst, src) \
{ \
tmp = (unsigned char)(src); \
+ if (tmp == 0 || tmp == '$') break; \
if ((unsigned int)(tmp -= 0x20) >= 0x60) return -1; \
tmp = BF_atoi64[tmp]; \
if (tmp > 63) return -1; \
@@ -624,6 +625,7 @@ static char *BF_crypt(const char *key, const char *setting,
return NULL;
}
+ memset(data.binary.salt, 0, sizeof data.binary.salt);
count = (BF_word)1 << ((setting[4] - '0') * 10 + (setting[5] - '0'));
if (count < min || BF_decode(data.binary.salt, &setting[7], 16)) {
return NULL;
--
2.7.4
next reply other threads:[~2016-03-25 12:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-25 12:12 Timo Teräs [this message]
2016-03-27 2:11 ` Solar Designer
2016-03-27 2:54 ` Solar Designer
2016-03-27 15:22 ` Solar Designer
2016-03-27 3:30 ` Solar Designer
2016-03-27 13:26 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1458907955-8698-1-git-send-email-timo.teras@iki.fi \
--to=timo.teras@iki.fi \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).