From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/10050 Path: news.gmane.org!not-for-mail From: Natanael Copa Newsgroups: gmane.linux.lib.musl.general Subject: [PATCH 1/2] check result from res_mkquery Date: Wed, 25 May 2016 11:22:13 +0200 Message-ID: <1464168134-17039-1-git-send-email-ncopa@alpinelinux.org> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1464168172 26629 80.91.229.3 (25 May 2016 09:22:52 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 25 May 2016 09:22:52 +0000 (UTC) Cc: Natanael Copa To: musl@lists.openwall.com Original-X-From: musl-return-10063-gllmg-musl=m.gmane.org@lists.openwall.com Wed May 25 11:22:51 2016 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1b5V1e-0004gC-2E for gllmg-musl@m.gmane.org; Wed, 25 May 2016 11:22:50 +0200 Original-Received: (qmail 17706 invoked by uid 550); 25 May 2016 09:22:44 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 17604 invoked from network); 25 May 2016 09:22:30 -0000 X-Mailer: git-send-email 2.8.2 Xref: news.gmane.org gmane.linux.lib.musl.general:10050 Archived-At: we don't want to try send a query that may be malformatted. --- src/network/lookup_name.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/network/lookup_name.c b/src/network/lookup_name.c index 86f90ac..d3d97b4 100644 --- a/src/network/lookup_name.c +++ b/src/network/lookup_name.c @@ -145,11 +145,15 @@ static int name_from_dns(struct address buf[static MAXADDRS], char canon[static if (family != AF_INET6) { qlens[nq] = __res_mkquery(0, name, 1, RR_A, 0, 0, 0, qbuf[nq], sizeof *qbuf); + if (qlens[nq] == -1) + return EAI_NONAME; nq++; } if (family != AF_INET) { qlens[nq] = __res_mkquery(0, name, 1, RR_AAAA, 0, 0, 0, qbuf[nq], sizeof *qbuf); + if (qlens[nq] == -1) + return EAI_NONAME; nq++; } -- 2.8.2