From: "Jörg Krause" <joerg.krause@embedded.rocks>
To: musl@lists.openwall.com
Subject: Re: Missing include of <string.h> in sched.h?
Date: Fri, 08 Sep 2017 11:26:38 +0200 [thread overview]
Message-ID: <1504862798.18993.3.camel@embedded.rocks> (raw)
In-Reply-To: <1504856816.12460.7.camel@embedded.rocks>
On Fri, 2017-09-08 at 09:46 +0200, Jörg Krause wrote:
> Hi,
>
> latest Boost 1.65.1 fails to compile with a musl toolchain [1].
>
> The issue is that Boost uses the `CPU_ZERO` macro which expands to
> `memset()` [2].
>
> The Linux Programmer's Manual state that memset() is defined in
> string.h [3].
>
> Therefore, shouldn't shed.h include string.h?
>
> [1] https://github.com/boostorg/fiber/pull/142
> [2] https://git.musl-libc.org/cgit/musl/tree/include/sched.h#n110
> [3] http://man7.org/linux/man-pages/man3/memset.3.html
On second thought, the forward declaration for memset() is missing [4].
Note, that there is a forward declaration for memcpy(), but it is never
used in sched.h.
[4] https://github.com/boostorg/fiber/pull/142#issuecomment-328043778
Best regards,
Jörg Krause
next prev parent reply other threads:[~2017-09-08 9:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-08 7:46 Jörg Krause
2017-09-08 8:49 ` Szabolcs Nagy
2017-09-08 9:44 ` Jörg Krause
2017-09-08 9:26 ` Jörg Krause [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-09-08 7:43 Jörg Krause
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1504862798.18993.3.camel@embedded.rocks \
--to=joerg.krause@embedded.rocks \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).