From mboxrd@z Thu Jan  1 00:00:00 1970
X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/11916
Path: news.gmane.org!.POSTED!not-for-mail
From: =?ISO-8859-1?Q?J=F6rg?= Krause <joerg.krause@embedded.rocks>
Newsgroups: gmane.linux.lib.musl.general
Subject: Re: Missing include of <string.h> in sched.h?
Date: Fri, 08 Sep 2017 11:44:11 +0200
Organization: Embedded Rocks
Message-ID: <1504863851.18993.6.camel@embedded.rocks>
References: <1504856816.12460.7.camel@embedded.rocks>
	 <20170908084937.GW15263@port70.net>
Reply-To: musl@lists.openwall.com
NNTP-Posting-Host: blaine.gmane.org
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
X-Trace: blaine.gmane.org 1504863891 10276 195.159.176.226 (8 Sep 2017 09:44:51 GMT)
X-Complaints-To: usenet@blaine.gmane.org
NNTP-Posting-Date: Fri, 8 Sep 2017 09:44:51 +0000 (UTC)
To: musl@lists.openwall.com
Original-X-From: musl-return-11929-gllmg-musl=m.gmane.org@lists.openwall.com Fri Sep 08 11:44:37 2017
Return-path: <musl-return-11929-gllmg-musl=m.gmane.org@lists.openwall.com>
Envelope-to: gllmg-musl@m.gmane.org
Original-Received: from mother.openwall.net ([195.42.179.200])
	by blaine.gmane.org with smtp (Exim 4.84_2)
	(envelope-from <musl-return-11929-gllmg-musl=m.gmane.org@lists.openwall.com>)
	id 1dqFpi-0001Hs-Ok
	for gllmg-musl@m.gmane.org; Fri, 08 Sep 2017 11:44:18 +0200
Original-Received: (qmail 20327 invoked by uid 550); 8 Sep 2017 09:44:24 -0000
Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm
Precedence: bulk
List-Post: <mailto:musl@lists.openwall.com>
List-Help: <mailto:musl-help@lists.openwall.com>
List-Unsubscribe: <mailto:musl-unsubscribe@lists.openwall.com>
List-Subscribe: <mailto:musl-subscribe@lists.openwall.com>
List-ID: <musl.lists.openwall.com>
Original-Received: (qmail 20306 invoked from network); 8 Sep 2017 09:44:24 -0000
In-Reply-To: <20170908084937.GW15263@port70.net>
X-Mailer: Evolution 3.24.5 
Xref: news.gmane.org gmane.linux.lib.musl.general:11916
Archived-At: <http://permalink.gmane.org/gmane.linux.lib.musl.general/11916>

On Fri, 2017-09-08 at 10:49 +0200, Szabolcs Nagy wrote:
> * Jörg Krause <joerg.krause@embedded.rocks> [2017-09-08 09:46:56 +0200]:
> > latest Boost 1.65.1 fails to compile with a musl toolchain [1].
> > 
> > The issue is that Boost uses the `CPU_ZERO` macro which expands to
> > `memset()` [2].
> > 
> > The Linux Programmer's Manual state that memset() is defined in
> > string.h [3].
> > 
> > Therefore, shouldn't shed.h include string.h?
> > 
> 
> it should probably include string.h and
> stdlib.h under _GNU_SOURCE
> 
> but note that would mean lot of namespace
> pollution for c++ which always defines
> _GNU_SOURCE

I proposed a patch [4] to add a forward declaration of memset() in
sched.h which indeed fixes the build issue.

> > [1] https://github.com/boostorg/fiber/pull/142
> > [2] https://git.musl-libc.org/cgit/musl/tree/include/sched.h#n110
> > [3] http://man7.org/linux/man-pages/man3/memset.3.html
> > 

[4] http://www.openwall.com/lists/musl/2017/09/08/4

Jörg Krause