mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Richard Pennington <rich@pennware.com>
To: musl@lists.openwall.com
Subject: Re: Possible ARM struct stat problem.
Date: Mon, 28 May 2012 08:13:48 -0500	[thread overview]
Message-ID: <1541470.svcjxmq1Ff@main.pennware.com> (raw)
In-Reply-To: <20120527194319.GF163@brightrain.aerifal.cx>

On Sunday, May 27, 2012 03:43:19 PM Rich Felker wrote:
> On Sun, May 27, 2012 at 01:35:07PM -0500, Richard Pennington wrote:
> > Hi,
> > 
> > I think a found a problem with the struct stat definition for the ARM. It
> > needed a bit more padding. I've attached a diff and wrote about it on my
> > blog if you'd like more information.
> > 
> > http://ellcc.org/blog/?p=121
> 
> This looks like a clang bug. Per the ABI, long long has 8-byte
> alignment on ARM. Thus, the structure definition musl has right now
> will give the right layout to match the ABI, and in fact it works
> perfectly when compiled with GCC.
> 
> I'm not entirely opposed to putting the explicit padding in there,
> since this is an arch-specific structure anyway, but I think you
> should check your compiler. The same issue might come up elsewhere and
> might not be so easy to work around.
> 
> Let me know what you find.
> 
> Rich

You were right, there is a problem with my compiler's ABI handling. I've 
patched it and have removed the padding. Thanks.

-Rich


  parent reply	other threads:[~2012-05-28 13:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-27 18:35 Richard Pennington
2012-05-27 19:43 ` Rich Felker
2012-05-27 23:03   ` Szabolcs Nagy
2012-05-28 13:13   ` Richard Pennington [this message]
2012-06-26  2:15   ` John Spencer
2012-06-26  2:50     ` Rich Felker
2012-06-26  2:52       ` Richard Pennington
2012-06-26  3:01         ` Rich Felker
2012-06-26  3:12       ` John Spencer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1541470.svcjxmq1Ff@main.pennware.com \
    --to=rich@pennware.com \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).