From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/937 Path: news.gmane.org!not-for-mail From: Richard Pennington Newsgroups: gmane.linux.lib.musl.general Subject: Re: Possible ARM struct stat problem. Date: Mon, 28 May 2012 08:13:48 -0500 Message-ID: <1541470.svcjxmq1Ff@main.pennware.com> References: <2314318.NDqLURy4mK@main.pennware.com> <20120527194319.GF163@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit X-Trace: dough.gmane.org 1338210912 25908 80.91.229.3 (28 May 2012 13:15:12 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 28 May 2012 13:15:12 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-938-gllmg-musl=m.gmane.org@lists.openwall.com Mon May 28 15:15:10 2012 Return-path: Envelope-to: gllmg-musl@plane.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1SYzmq-000160-MX for gllmg-musl@plane.gmane.org; Mon, 28 May 2012 15:15:04 +0200 Original-Received: (qmail 12132 invoked by uid 550); 28 May 2012 13:15:03 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 12124 invoked from network); 28 May 2012 13:15:03 -0000 X-Authority-Analysis: v=2.0 cv=ae7jbGUt c=1 sm=0 a=/l7PkcR/UKDnn7Q2wmGJww==:17 a=hdNgKtvFP3AA:10 a=fR_ARpL9IlcA:10 a=5UDJ85XU0lMA:10 a=msTO8fkKGJEA:10 a=kj9zAlcOel0A:10 a=N4Ps669bAAAA:8 a=fJQ8rcZWAAAA:8 a=GQ5y19XFHIUr8-0_uLcA:9 a=CjuIK1q_8ugA:10 a=/l7PkcR/UKDnn7Q2wmGJww==:117 X-Cloudmark-Score: 0 X-Originating-IP: 65.26.59.215 User-Agent: KMail/4.8.3 (Linux/3.3.2-6.fc16.x86_64; KDE/4.8.3; x86_64; ; ) In-Reply-To: <20120527194319.GF163@brightrain.aerifal.cx> Xref: news.gmane.org gmane.linux.lib.musl.general:937 Archived-At: On Sunday, May 27, 2012 03:43:19 PM Rich Felker wrote: > On Sun, May 27, 2012 at 01:35:07PM -0500, Richard Pennington wrote: > > Hi, > > > > I think a found a problem with the struct stat definition for the ARM. It > > needed a bit more padding. I've attached a diff and wrote about it on my > > blog if you'd like more information. > > > > http://ellcc.org/blog/?p=121 > > This looks like a clang bug. Per the ABI, long long has 8-byte > alignment on ARM. Thus, the structure definition musl has right now > will give the right layout to match the ABI, and in fact it works > perfectly when compiled with GCC. > > I'm not entirely opposed to putting the explicit padding in there, > since this is an arch-specific structure anyway, but I think you > should check your compiler. The same issue might come up elsewhere and > might not be so easy to work around. > > Let me know what you find. > > Rich You were right, there is a problem with my compiler's ABI handling. I've patched it and have removed the padding. Thanks. -Rich