From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/14278 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Andre McCurdy Newsgroups: gmane.linux.lib.musl.general Subject: [PATCH] drop unused extra char from getnameinfo() local buffer Date: Thu, 27 Jun 2019 17:54:33 -0700 Message-ID: <1561683273-18265-1-git-send-email-armccurdy@gmail.com> Reply-To: musl@lists.openwall.com Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="211770"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Andre McCurdy To: musl@lists.openwall.com Original-X-From: musl-return-14294-gllmg-musl=m.gmane.org@lists.openwall.com Fri Jun 28 02:54:58 2019 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.89) (envelope-from ) id 1hgfAH-000ssl-K1 for gllmg-musl@m.gmane.org; Fri, 28 Jun 2019 02:54:57 +0200 Original-Received: (qmail 19834 invoked by uid 550); 28 Jun 2019 00:54:54 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 19802 invoked from network); 28 Jun 2019 00:54:53 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=XLqXnA5GAsCz21ls/R/Fv8xQKxzLHtsgIxD1Q6neQsk=; b=cqv580YeVe32X/qLW8+tcc/5N2JjSI1YApBaMHaNHrrFXtFaAIPQfntudYhzziSwe3 zptRiIpJmzlgASNuCKPtlGCjJtEgO4UwRsVAsQnFF27yuqx2F6oy87RCOYajQVMEVZBq blkRAjmKt+ldSJaJgF6aVG9QScUzZtAjFTRWo6MiKCwI+xUJFO2xtFHMz74More2gdoK 5JI4xD8wmrClH/axIJNFKmGz1eajR6HrwW79gesad6jROcnxdt52PHVIDh3k2QHmjgPk 1a+c7qw1UG+rkSkWPjO/1vFv6J32Io/2ii6aZR+BqiNqkG35nKYS3UpfhvP8s5SIVjKe EqVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=XLqXnA5GAsCz21ls/R/Fv8xQKxzLHtsgIxD1Q6neQsk=; b=R1SkrH8CxPUR9JEfu24r3CGBz869+LjXV8KrGGyLvXhU2sT50egpjTF59otEdNw3Cm BhUKItPYnf2AphIyMs5qSdT28VF6DLwdymNv9fD1mbG8pHY8bgEXKRGowqrWuKFyyRmq Bthp0ayqko0lA1W04eeFCw9QaGlyfpyKHoRZnxgxTrbdBqZjQc/u3lbCEabmADBAH9q7 MuiOXfI71EVf88n4Li1R9/zMQ34Hi/yxOLWU3jTxuYoWKVoY9qwujf6rRmEIaqi1uvMX iCWHndHW9Mz4aDAIKawfFbN12LwAi81XVF/jETl7r9pWZIaf1xybf3nvdwgcQqQXvlp+ WZtw== X-Gm-Message-State: APjAAAUWaimbxjPUo40MjIht7QWayptBW2krjVUgPbfxBNgegQHWevdQ 2U1aoJ2Jga4OPduXjDqdYtxmdcmp X-Google-Smtp-Source: APXvYqwB2iExcR/1n++efdclXmpTAeeouJVOepmPJcW2StA65+E2xCzK8ur5qgvGU/xaKDHRn7M/jg== X-Received: by 2002:a63:4e5f:: with SMTP id o31mr6669552pgl.49.1561683281486; Thu, 27 Jun 2019 17:54:41 -0700 (PDT) X-Mailer: git-send-email 1.9.1 Xref: news.gmane.org gmane.linux.lib.musl.general:14278 Archived-At: The num local buffer is only passed to itoa(), which expects a buffer size of 3*sizeof(int), not 3*sizeof(int)+1. Also change the data type of the port local variable to clarify that itoa() only handles unsigned values. --- src/network/getnameinfo.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/network/getnameinfo.c b/src/network/getnameinfo.c index f77e73a..02c2c09 100644 --- a/src/network/getnameinfo.c +++ b/src/network/getnameinfo.c @@ -124,7 +124,7 @@ int getnameinfo(const struct sockaddr *restrict sa, socklen_t sl, int flags) { char ptr[PTR_MAX]; - char buf[256], num[3*sizeof(int)+1]; + char buf[256], num[3*sizeof(int)]; int af = sa->sa_family; unsigned char *a; unsigned scopeid; @@ -184,7 +184,7 @@ int getnameinfo(const struct sockaddr *restrict sa, socklen_t sl, if (serv && servlen) { char *p = buf; - int port = ntohs(((struct sockaddr_in *)sa)->sin_port); + unsigned port = ntohs(((struct sockaddr_in *)sa)->sin_port); buf[0] = 0; if (!(flags & NI_NUMERICSERV)) reverse_services(buf, port, flags & NI_DGRAM); -- 1.9.1