From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/12557 Path: news.gmane.org!.POSTED!not-for-mail From: "Zhao, Weiming" Newsgroups: gmane.linux.lib.musl.general Subject: clz instruction is unavailable for Thumb1 Date: Tue, 27 Feb 2018 16:03:19 -0800 Message-ID: <1799b81c-10d6-c2ac-4411-6ee9808f2356@codeaurora.org> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1519776112 613 195.159.176.226 (28 Feb 2018 00:01:52 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 28 Feb 2018 00:01:52 +0000 (UTC) User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 To: musl@lists.openwall.com Original-X-From: musl-return-12573-gllmg-musl=m.gmane.org@lists.openwall.com Wed Feb 28 01:01:48 2018 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.84_2) (envelope-from ) id 1eqpBs-00087m-5n for gllmg-musl@m.gmane.org; Wed, 28 Feb 2018 01:01:48 +0100 Original-Received: (qmail 16262 invoked by uid 550); 28 Feb 2018 00:03:48 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 16184 invoked from network); 28 Feb 2018 00:03:32 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1519776200; bh=dvUzECTklTB3L14fbNNkxemnKByfixCFgG5a9FQGDy0=; h=To:From:Subject:Date:From; b=Vum9+IMH0pCo57fPaE9CuovMNQoQ84tlvu5oMk1/xmG1/sB4T0CyyShixW3e+9r7k tWQM5ClCAx/Zpn+MUDb4MbSPKPxkBusD4iNj7OSsXQxN1kJIzlkMzi5NUK4HIrECm/ eapTPEqxY3Z274h4ZuNJmD4eBc84+8WY1wtM4DTA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1519776200; bh=dvUzECTklTB3L14fbNNkxemnKByfixCFgG5a9FQGDy0=; h=To:From:Subject:Date:From; b=Vum9+IMH0pCo57fPaE9CuovMNQoQ84tlvu5oMk1/xmG1/sB4T0CyyShixW3e+9r7k tWQM5ClCAx/Zpn+MUDb4MbSPKPxkBusD4iNj7OSsXQxN1kJIzlkMzi5NUK4HIrECm/ eapTPEqxY3Z274h4ZuNJmD4eBc84+8WY1wtM4DTA= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 6358A60117 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=weimingz@codeaurora.org Content-Language: en-US Xref: news.gmane.org gmane.linux.lib.musl.general:12557 Archived-At: In arch/arm/atomic_arch.h, it checks for __ARM_ARCH >= 5, which is not sufficient. for example, for armv6-m, it only support Thumb1, which doesn't include clz. Suggest to check if it's building for thumb1: diff --git a/arch/arm/atomic_arch.h b/arch/arm/atomic_arch.h index c5c56f8..e3cb66a 100644 --- a/arch/arm/atomic_arch.h +++ b/arch/arm/atomic_arch.h @@ -82,7 +82,7 @@ static inline void a_crash()                 : : : "memory");  } -#if __ARM_ARCH >= 5 +#if __ARM_ARCH >= 5 && !(defined(__thumb__) && !defined(__thumb2)) -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation