mailing list of musl libc
 help / color / mirror / code / Atom feed
From: puwenxu <puwenxu1@huawei.com>
To: "musl@lists.openwall.com" <musl@lists.openwall.com>
Subject: [musl] Question on 2b2c8aafce9d80f9d58652643538f4d58e82b856
Date: Sun, 30 Oct 2022 06:29:54 +0000	[thread overview]
Message-ID: <1903ff21f49146998d843cc2860f7166@huawei.com> (raw)


[-- Attachment #1.1: Type: text/plain, Size: 843 bytes --]

Dear maintainer,
       I'm using musl 1.2.3.0 now. When I was running some test case codes for musl, I found there may be a problem on modification of 2b2c8aafce9d80f9d58652643538f4d58e82b856.
       As you can see in the picture, this modification assign buf to orig. Then, the orig will be assigned to buf again. If the original value of buf is NULL, the latter value of the buf will be NULL. However, assign out to buf will fail if buf is NULL.
       [cid:image001.png@01D8EC6C.12AE8540]
       I have written a simple file to verification my opinion. The test code and output is shown in the following picture. I think it may be better to add a check for buf in this situation.
       [cid:image002.png@01D8EC6C.12AE8540]
[cid:image003.png@01D8EC6C.12AE8540]
Looking forward to your reply.



Wish Pu
       OS Kernel Lab


[-- Attachment #1.2: Type: text/html, Size: 4674 bytes --]

[-- Attachment #2: image001.png --]
[-- Type: image/png, Size: 100094 bytes --]

[-- Attachment #3: image002.png --]
[-- Type: image/png, Size: 101290 bytes --]

[-- Attachment #4: image003.png --]
[-- Type: image/png, Size: 4073 bytes --]

             reply	other threads:[~2022-10-30 11:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-30  6:29 puwenxu [this message]
2022-10-30 13:11 ` Sam James
2022-10-30 14:31 ` Rich Felker
2022-10-30 17:11 ` Markus Wichmann
2022-10-31 15:41 puwenxu
2022-10-31 17:25 ` Rich Felker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1903ff21f49146998d843cc2860f7166@huawei.com \
    --to=puwenxu1@huawei.com \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).