From: CodingMarkus <CodingMarkus@hanauska.name>
To: musl@lists.openwall.com
Subject: Why are stdin/stdout/stderr `FILE *const` in musl?
Date: Fri, 2 Feb 2018 14:24:28 +0100 [thread overview]
Message-ID: <1E109BA9-57C0-42DB-9B43-8ADE27F9E76C@hanauska.name> (raw)
Hello everyone!
Just a quick question:
Why does musl define stdin, stdout, and stderr to be of type `FILE *const`? Neither the C standard, nor the POSIX standard require, recommend or even imply that it would be allowed that this is a `const` pointer. That’s why other C libraries define it as `FILE *` only because that matches the examples given by POSIX and that matches the description found in any ISO-C standard. Making them const only break compatibility with other C libraries, e.g. considered this code:
void * getOutputPtr ( void ) {
if (/* whatever */) {
return &stdout;
}
return &stderr;
}
This code is correct by C standard and it is correct by POSIX standard but it won’t compile with strict compiler settings when using musl as the compiler complains that the `const` is lost and there is no explicitly cast for that.
error: cannot initialize return object of type 'void *' with an rvalue of type 'FILE *const *'
The reason why there is no cast is because a C programmer doesn’t have to expect a const here and thus this code would usually not require a cast. I don’t know what the intention is behind making stdX const, it’s probably a good one, but if that makes your header files incompatible to both, C and POSIX standard, then it is a horrible change that only means trouble and will not improve anything for anyone.
Regards,
Markus
next reply other threads:[~2018-02-02 13:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-02 13:24 CodingMarkus [this message]
2018-02-02 13:54 ` Jens Gustedt
2018-02-02 14:13 ` Alexander Monakov
2018-02-02 15:01 ` Markus Wichmann
2018-02-02 15:30 ` CodingMarkus
[not found] ` <CAOUYtQAWqEY_Ys3crsyXDmVVqJVjfzwTA0NsDxfpgU5cP_t2nA@mail.gmail.com>
2018-02-02 15:53 ` Jon Chesterfield
2018-02-02 16:01 ` Jens Gustedt
2018-02-02 16:12 ` Jeff Hammond
2018-02-02 17:16 ` William Pitcock
2018-02-02 17:35 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1E109BA9-57C0-42DB-9B43-8ADE27F9E76C@hanauska.name \
--to=codingmarkus@hanauska.name \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).