From: Rich Felker <dalias@aerifal.cx>
To: musl@lists.openwall.com
Subject: Re: [PATCH] add eventfd syscall wrapper and helper
Date: Thu, 5 May 2011 00:15:56 -0400 [thread overview]
Message-ID: <20110505041556.GP277@brightrain.aerifal.cx> (raw)
In-Reply-To: <1304539185-25729-1-git-send-email-ftrvxmtrx@gmail.com>
On Wed, May 04, 2011 at 10:59:45PM +0300, Serge Ziryukin wrote:
> abstractions are:
>
> typedef uint64_t eventfd_t;
> int eventfd_read(int fd, eventfd_t *value);
> int eventfd_write(int fd, eventfd_t value);
>
> these are trying to hide the details of reading and writing
> on an eventfd descriptor.
Seems silly, but if that's the usual API I have no objections. It's
small anyway.
> +int eventfd(unsigned int count, int flags)
> +{
> + return syscall(SYS_eventfd, count, flags);
> +}
Shouldn't this be flags ? SYS_eventfd2 : SYS_eventfd...? The old
SYS_eventfd supposedly does not support flags.
Rich
next prev parent reply other threads:[~2011-05-05 4:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-04 19:59 [PATCH] add eventfd syscall wrapper and helper abstractions as in glibc Serge Ziryukin
2011-05-05 4:15 ` Rich Felker [this message]
2011-05-05 5:27 ` [PATCH] add eventfd syscall wrapper and helper Serge Ziryukin
2011-05-05 5:30 ` [PATCH] add eventfd syscall wrapper and helper abstractions as in glibc Serge Ziryukin
2011-05-08 4:26 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110505041556.GP277@brightrain.aerifal.cx \
--to=dalias@aerifal.cx \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).